Paths

Table of Contentst

Differential D12409

Conpherence - make timestamps in durable column link to full message in conpherence
ClosedPublic
Actions

Authored by btrahan on Apr 14 2015, 5:37 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Apr 30, 5:14 PM

	Unknown Object (File)
	Tue, Apr 30, 5:14 PM

	Unknown Object (File)
	Tue, Apr 30, 5:14 PM

	Unknown Object (File)
	Mon, Apr 29, 2:21 PM

	Unknown Object (File)
	Fri, Apr 12, 2:40 AM

	Unknown Object (File)
	Mar 22 2024, 8:42 PM

	Unknown Object (File)
	Mar 4 2024, 5:09 PM

	Unknown Object (File)
	Jan 31 2024, 2:24 AM

Subscribers

Details

Reviewers

epriestley
chad

Maniphest Tasks

T7757: Conpherence rooms should offer permanent links to a specific message

Commits

Restricted Diffusion Commit
rPd90496a7192d: Conpherence - make timestamps in durable column link to full message in…

Summary

Ref T7757. This diff made me realize that PhabricatorTransactionView is only used in Conpherence, as well as that ConpherenceTransactionView is more like a rendering class with a few static methods. Going to take a diff after this to clean all that up.

Test Plan

opened up durable column, clicked on timestamp, voila!

Diff Detail

Repository

Branch

T7757

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 5309
Build 5327: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 29808.Apr 14 2015, 5:37 PM

btrahan added a task: T7757: Conpherence rooms should offer permanent links to a specific message.

btrahan retitled this revision from to Conpherence - make timestamps in durable column link to full message in conpherence.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added a reviewer: chad. · View Herald TranscriptApr 14 2015, 5:37 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.Apr 14 2015, 6:10 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Apr 14 2015, 6:10 PM

Closed by commit rPd90496a7192d: Conpherence - make timestamps in durable column link to full message in… (authored by btrahan, committed by btrahan). · Explain WhyApr 14 2015, 6:28 PM

This revision was automatically updated to reflect the committed changes.

btrahan mentioned this in D12410: Conpherence - refactor display classes a bit.Apr 14 2015, 6:31 PM

btrahan mentioned this in rP87d360bb1b4a: Conpherence - refactor display classes a bit.Apr 14 2015, 7:25 PM

Revision Contents
Changeset List

Path

Size

resources/

celerity/

4 lines

src/

applications/

conpherence/

view/

ConpherenceTransactionView.php

18 lines

view/

layout/

PhabricatorTransactionView.php

18 lines

webroot/

rsrc/

css/

application/

conpherence/

durable-column.css

4 lines

Diff 29808

resources/celerity/map.php

Loading...

src/applications/conpherence/view/ConpherenceTransactionView.php

Loading...

src/view/layout/PhabricatorTransactionView.php

Loading...

webroot/rsrc/css/application/conpherence/durable-column.css

Loading...