Fixes T7786. Adds very basic mailtag support.
Details
Details
- Reviewers
epriestley btrahan - Maniphest Tasks
- T7786: Paste Notifications can't be set to ignore or email in preferences
- Commits
- Restricted Diffusion Commit
rPca5909cac6c4: Add Mailtags to Paste
Tested changing language, title to a Paste, didn't get notifications on my test account.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- paste-notifications
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 5300 Build 5318: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
I think we should separate "comment" out, but maybe lump "title" and "content" into a single category, and put "language" with "other"? So the options would be:
- Content is changed (title or body).
- Comment.
- Other.
Particularly, my guess is that "comment" is much more interesting to separate out than "language".
Comment Actions
You can look at, e.g., DifferentialTransaction->getMailTags() for an example. It should be:
PhabricatorTransactions::TYPE_COMMENT
| src/applications/paste/editor/PhabricatorPasteEditor.php | ||
|---|---|---|
| 160 | ...and then this one becomes PhabricatorPasteTransaction::MAILTAG_COMMENT | |
| src/applications/paste/storage/PhabricatorPasteTransaction.php | ||
| 12 | Oh, sorry -- you do need to add MAILTAG_COMMENT here... | |
| 198 | ...and do: case PhabricatorTransactions::TYPE_COMMENT: $tag[] = self::MAILTAG_COMMENT; ...here | |