Page MenuHomePhabricator
Differential D12388

Various linter fixes
ClosedPublic
Actions

Authored by joshuaspence on Apr 13 2015, 9:51 AM.
Tags
None
Referenced Files
F13234017: D12388.diff
Tue, May 21, 2:43 AM
F13228516: D12388.id.diff
Mon, May 20, 10:04 AM
F13212298: D12388.diff
Fri, May 17, 6:34 AM
F13195842: D12388.diff
Sun, May 12, 10:40 PM
F13180948: D12388.diff
Thu, May 9, 6:24 AM
F13179748: D12388.diff
Wed, May 8, 9:25 PM
Unknown Object (File)
Sat, May 4, 7:02 PM
Unknown Object (File)
Thu, May 2, 6:01 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARC7bba30f66cee: Various linter fixes
Summary

Apply various linter fixes.

Test Plan

Unit tests + eyeballing.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 29733.Apr 13 2015, 9:51 AM
joshuaspence retitled this revision from to Various linter fixes.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 13 2015, 9:51 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Apr 13 2015, 2:24 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 13 2015, 2:24 PM
Closed by commit rARC7bba30f66cee: Various linter fixes (authored by joshuaspence, committed by joshuaspence). · Explain WhyApr 13 2015, 8:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
differential/
constants/
6 lines
parser/
diff/
24 lines
repository/
api/
4 lines
workflow/
2 lines

Diff 29783

View Options

src/differential/constants/ArcanistDifferentialRevisionHash.php

Loading...
View Options

src/parser/diff/ArcanistDiffChangeType.php

Loading...
View Options

src/repository/api/ArcanistGitAPI.php

Loading...
View Options

src/workflow/ArcanistAliasWorkflow.php

Loading...
Phabricator · Built by Phacility