Page MenuHomePhabricator
Differential D12396

Conpherence - us JX.Scrollbar in main conpherence view
ClosedPublic
Actions

Authored by btrahan on Apr 13 2015, 6:33 PM.
Tags
None
Referenced Files
F14823258: D12396.id.diff
Tue, Jan 28, 11:37 AM
Unknown Object (File)
Sun, Jan 26, 4:33 PM
Unknown Object (File)
Sun, Jan 26, 4:33 PM
Unknown Object (File)
Sun, Jan 26, 4:33 PM
Unknown Object (File)
Sun, Jan 26, 4:23 PM
Unknown Object (File)
Sun, Jan 26, 11:25 AM
Unknown Object (File)
Fri, Jan 24, 2:34 AM
Unknown Object (File)
Fri, Jan 24, 2:34 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T7681: Main Conpherence UI should use JX.Scrollbar
Commits
Restricted Diffusion Commit
rPe5ff344d0d72: Conpherence - us JX.Scrollbar in main conpherence view
Summary

Fixes T7681. Relatively straight forward since we don't "destroy" the main div the scroll bar is attached to, and instead just update the interior content.

Test Plan

played with conpherence in main view and scrolling never broke

Diff Detail

Repository
rP Phabricator
Branch
T7681
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5291
Build 5309: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 29748.Apr 13 2015, 6:33 PM
btrahan added a task: T7681: Main Conpherence UI should use JX.Scrollbar.
btrahan retitled this revision from to Conpherence - us JX.Scrollbar in main conpherence view.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptApr 13 2015, 6:33 PM
epriestley accepted this revision.Apr 13 2015, 6:41 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 13 2015, 6:41 PM
Closed by commit rPe5ff344d0d72: Conpherence - us JX.Scrollbar in main conpherence view (authored by btrahan, committed by btrahan). · Explain WhyApr 13 2015, 6:49 PM
This revision was automatically updated to reflect the committed changes.
chad mentioned this in T7825: Conpherence: Sent text floats below breadcrumb-bar.Apr 14 2015, 7:28 PM

Revision Contents
Changeset List

PathSize
resources/
celerity/
61 lines
webroot/
rsrc/
js/
application/
conpherence/
15 lines
2 lines

Diff 29748

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/js/application/conpherence/behavior-menu.js

Loading...
View Options

webroot/rsrc/js/application/conpherence/behavior-widget-pane.js

Loading...
Phabricator · Built by Phacility