Page MenuHomePhabricator
Differential D12394

Move Conpherence when warning is present
ClosedPublic
Actions

Authored by chad on Apr 13 2015, 5:16 PM.
Tags
None
Referenced Files
F13149973: D12394.diff
Sat, May 4, 12:36 PM
Unknown Object (File)
Fri, Apr 26, 8:55 AM
Unknown Object (File)
Thu, Apr 25, 2:24 AM
Unknown Object (File)
Apr 2 2024, 12:05 PM
Unknown Object (File)
Mar 4 2024, 11:07 PM
Unknown Object (File)
Feb 14 2024, 1:41 PM
Unknown Object (File)
Feb 14 2024, 1:34 PM
Unknown Object (File)
Feb 14 2024, 1:33 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Maniphest Tasks
T5095: Workboards looks weird when there's an unresolved setup issue
Commits
Restricted Diffusion Commit
rPd56012ce262b: Move Conpherence when warning is present
Summary

Turns out only Conpherence/Durable Column still have issues. Workboards is OK. Simple 2 new CSS classes and punt the issue down the road.

Test Plan

Test Workboards, Conpherence, Durable Column with a setup check issue.

Diff Detail

Repository
rP Phabricator
Branch
toc
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5288
Build 5306: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 29742.Apr 13 2015, 5:16 PM
chad retitled this revision from to Move Conpherence when warning is present.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptApr 13 2015, 5:16 PM
epriestley accepted this revision.Apr 13 2015, 5:17 PM
epriestley edited edge metadata.

haha

I do think we should consider shoving this somewhere else sooner or later, but this is easy enough.

This revision is now accepted and ready to land.Apr 13 2015, 5:17 PM
chad added a comment.Apr 13 2015, 5:24 PM

Unintended side effect, the issue is now fixed on scroll. Not sure if awesome or bad.

pasted_file (326×594 px, 103 KB)

Closed by commit rPd56012ce262b: Move Conpherence when warning is present (authored by chad, committed by chad). · Explain WhyApr 13 2015, 5:30 PM
This revision was automatically updated to reflect the committed changes.
chad added a task: T5095: Workboards looks weird when there's an unresolved setup issue.Apr 13 2015, 5:34 PM

Revision Contents
Changeset List

PathSize
resources/
celerity/
8 lines
src/
view/
page/
9 lines
webroot/
rsrc/
css/
application/
conpherence/
4 lines
4 lines

Diff 29742

View Options

resources/celerity/map.php

Loading...
View Options

src/view/page/PhabricatorStandardPageView.php

Loading...
View Options

webroot/rsrc/css/application/conpherence/durable-column.css

Loading...
View Options

webroot/rsrc/css/application/conpherence/menu.css

Loading...
Phabricator · Built by Phacility