Paths

Table of Contentst

Differential D12389

Add a linter rule for declaring nested functions
ClosedPublic
Actions

Authored by joshuaspence on Apr 13 2015, 10:50 AM.

Tags

None

Referenced Files

	F14080143: D12389.id29737.diff
	Fri, Nov 22, 11:42 AM

	F14080142: D12389.id29784.diff
	Fri, Nov 22, 11:42 AM

	F14080141: D12389.id29735.diff
	Fri, Nov 22, 11:41 AM

	Unknown Object (File)
	Tue, Nov 12, 5:59 AM

	Unknown Object (File)
	Sat, Nov 9, 8:33 PM

	Unknown Object (File)
	Sat, Nov 9, 5:56 PM

	Unknown Object (File)
	Wed, Oct 30, 6:43 AM

	Unknown Object (File)
	Sun, Oct 27, 6:08 PM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T7409: Implement PHPCS lints

Commits

rARCe233b158f2e1: Add a linter rule for declaring nested functions

Summary

Ref T7409. Adds ArcanistXHPASTLinter::LINT_INNER_FUNCTION to advise against declaring PHP functions within an outer function. Based on Squiz_Sniffs_PHP_InnerFunctionsSniff.

Test Plan

Added unit tests.

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 5281
Build 5299: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed
View All

	Time	Test
	9,286 ms	ArcanistXHPASTLinterTestCase::testLinter
	823 ms	ArcanistCSSLintLinterTestCase::testLinter
	151 ms	ArcanistCSSLintLinterTestCase::testVersion
	131 ms	ArcanistChmodLinterTestCase::testLinter
	247 ms	ArcanistClosureLinterTestCase::testLinter
		View Full Test Results (1 Failed · 46 Passed · 6 Skipped)

Event Timeline

joshuaspence updated this revision to Diff 29735.Apr 13 2015, 10:50 AM

joshuaspence retitled this revision from to Add a linter rule for declaring nested functions.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T7409: Implement PHPCS lints.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 13 2015, 10:50 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

Better detection of closures

"Rocks are heavy and rigid. Avoid hitting yourself in the face with a rock."

This revision is now accepted and ready to land.Apr 13 2015, 2:27 PM

Closed by commit rARCe233b158f2e1: Add a linter rule for declaring nested functions (authored by joshuaspence, committed by joshuaspence). · Explain WhyApr 13 2015, 8:32 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistXHPASTLinter.php

26 lines

__tests__/

xhpast/

inner-function.lint-test

16 lines

reused-iterator-reference.lint-test

3 lines

Diff 29735

src/lint/linter/ArcanistXHPASTLinter.php

Loading...

src/lint/linter/tests/xhpast/inner-function.lint-test

Loading...

src/lint/linter/tests/xhpast/reused-iterator-reference.lint-test

Loading...