Page MenuHomePhabricator
Differential D12388

Various linter fixes
ClosedPublic
Actions

Authored by joshuaspence on Apr 13 2015, 9:51 AM.
Tags
None
Referenced Files
F15526007: D12388.diff
Mon, Apr 21, 6:28 PM
F15522291: D12388.diff
Sun, Apr 20, 7:21 PM
F15424908: D12388.id29783.diff
Mar 23 2025, 1:04 AM
Unknown Object (File)
Mar 1 2025, 12:05 PM
Unknown Object (File)
Feb 18 2025, 4:20 PM
Unknown Object (File)
Feb 13 2025, 9:27 PM
Unknown Object (File)
Feb 8 2025, 3:25 AM
Unknown Object (File)
Feb 1 2025, 8:40 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARC7bba30f66cee: Various linter fixes
Summary

Apply various linter fixes.

Test Plan

Unit tests + eyeballing.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5279
Build 5297: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 29733.Apr 13 2015, 9:51 AM
joshuaspence retitled this revision from to Various linter fixes.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 13 2015, 9:51 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Apr 13 2015, 2:24 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 13 2015, 2:24 PM
Closed by commit rARC7bba30f66cee: Various linter fixes (authored by joshuaspence, committed by joshuaspence). · Explain WhyApr 13 2015, 8:32 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
differential/
constants/
6 lines
parser/
diff/
24 lines
repository/
api/
4 lines
workflow/
2 lines

Diff 29733

View Options

src/differential/constants/ArcanistDifferentialRevisionHash.php

Loading...
View Options

src/parser/diff/ArcanistDiffChangeType.php

Loading...
View Options

src/repository/api/ArcanistGitAPI.php

Loading...
View Options

src/workflow/ArcanistAliasWorkflow.php

Loading...
Phabricator · Built by Phacility