Page MenuHomePhabricator

Add a linter rule for logical operators
ClosedPublic

Authored by joshuaspence on Apr 12 2015, 9:07 PM.
Tags
None
Referenced Files
F15410009: D12376.diff
Wed, Mar 19, 6:33 AM
F15387633: D12376.id29715.diff
Sat, Mar 15, 2:43 AM
Unknown Object (File)
Sat, Feb 22, 10:26 PM
Unknown Object (File)
Fri, Feb 21, 3:06 PM
Unknown Object (File)
Feb 13 2025, 2:06 AM
Unknown Object (File)
Feb 13 2025, 2:06 AM
Unknown Object (File)
Feb 13 2025, 2:05 AM
Unknown Object (File)
Feb 13 2025, 1:57 AM
Subscribers

Details

Summary

Ref T7409. Adds ArcanistXHPASTLinter::LINT_LOGICAL_OPERATORS for advising:

  • && in favor of and.
  • || in favor of or.

Based on Squiz_Sniffs_Operators_ValidLogicalOperatorsSniff.

Test Plan

Added test cases.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence retitled this revision from to Add a linter rule for logical operators.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 12 2015, 9:10 PM
src/lint/linter/ArcanistXHPASTLinter.php
3471

Should be %s, not %.

3479

Likewise.

joshuaspence edited edge metadata.

Rebase, fix pht format string

This revision was automatically updated to reflect the committed changes.