Paths

Table of Contentst

Differential D12376

Add a linter rule for logical operators
ClosedPublic
Actions

Authored by joshuaspence on Apr 12 2015, 9:07 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T7409: Implement PHPCS lints

Commits

rARCb11757fa23a5: Add a linter rule for logical operators

Summary

Ref T7409. Adds ArcanistXHPASTLinter::LINT_LOGICAL_OPERATORS for advising:

&& in favor of and.
|| in favor of or.

Based on Squiz_Sniffs_Operators_ValidLogicalOperatorsSniff.

Test Plan

Added test cases.

Diff Detail

Repository

rARC Arcanist

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 5262
Build 5280: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 29708.Apr 12 2015, 9:07 PM

joshuaspence retitled this revision from to Add a linter rule for logical operators.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T7409: Implement PHPCS lints.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 12 2015, 9:07 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.Apr 12 2015, 9:10 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Apr 12 2015, 9:10 PM

epriestley added inline comments.Apr 12 2015, 9:10 PM

src/lint/linter/ArcanistXHPASTLinter.php
3420	Should be `%s`, not `%`.
3428	Likewise.

Rebase, fix pht format string

Closed by commit rARCb11757fa23a5: Add a linter rule for logical operators (authored by joshuaspence, committed by joshuaspence). · Explain WhyApr 12 2015, 9:38 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistXHPASTLinter.php

27 lines

__tests__/

xhpast/

logical-operators.lint-test

22 lines

Diff 29708

View Options

src/lint/linter/ArcanistXHPASTLinter.php

View Options

src/lint/linter/tests/xhpast/logical-operators.lint-test

Add a linter rule for logical operatorsClosedPublicActions