Page MenuHomePhabricator
Differential D12344

Fix XHPAST parsing of casts
ClosedPublic
Actions

Authored by joshuaspence on Apr 10 2015, 1:58 PM.
Tags
None
Referenced Files
F15422484: D12344.id29672.diff
Sat, Mar 22, 8:41 AM
F15411789: D12344.id29672.diff
Wed, Mar 19, 9:49 AM
F15410372: D12344.id29656.diff
Wed, Mar 19, 7:14 AM
F15407605: D12344.id.diff
Tue, Mar 18, 6:40 PM
F15400248: D12344.diff
Mon, Mar 17, 10:34 AM
F15390338: D12344.id29656.diff
Sat, Mar 15, 6:08 AM
F15386113: D12344.id.diff
Sat, Mar 15, 12:03 AM
F15338362: D12344.diff
Sun, Mar 9, 10:39 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T7801: XHPAST is behaving strangely
Commits
rPHUefc338d50f17: Fix XHPAST parsing of casts
Summary

Fixes T7801.

Test Plan

Went to http://phabricator.local/xhpast/ and inspected the parse tree for $x = (double) $y.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningsupport/xhpast/scanner.l:307TXT3Line Too Long
Unit
No Test Coverage
Build Status
Buildable 5223
Build 5241: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 29656.Apr 10 2015, 1:58 PM
joshuaspence retitled this revision from to Fix XHPAST parsing of casts.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
joshuaspence added a task: T7801: XHPAST is behaving strangely.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 10 2015, 1:58 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Apr 10 2015, 2:01 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 10 2015, 2:01 PM
Closed by commit rPHUefc338d50f17: Fix XHPAST parsing of casts (authored by joshuaspence, committed by joshuaspence). · Explain WhyApr 11 2015, 11:50 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
support/
xhpast/
455 lines
7267 lines
3 lines
29 lines
4270 lines

Diff 29656

View Options

support/xhpast/parser.yacc.hpp

Loading...
View Options

support/xhpast/parser.yacc.cpp

Loading...
View Options

support/xhpast/scanner.l

Loading...
View Options

support/xhpast/scanner.lex.hpp

Loading...
View Options

support/xhpast/scanner.lex.cpp

Loading...
Phabricator · Built by Phacility