Page MenuHomePhabricator
Differential D12340

Remove some callsites to loadViewerHandles()
ClosedPublic
Actions

Authored by epriestley on Apr 9 2015, 10:26 PM.
Tags
None
Referenced Files
F13182416: D12340.diff
Thu, May 9, 11:28 PM
Unknown Object (File)
Mon, May 6, 2:41 AM
Unknown Object (File)
Sun, May 5, 4:20 AM
Unknown Object (File)
Sat, May 4, 3:52 AM
Unknown Object (File)
Fri, May 3, 3:30 AM
Unknown Object (File)
Wed, May 1, 8:10 PM
Unknown Object (File)
Sun, Apr 28, 9:32 AM
Unknown Object (File)
Sun, Apr 28, 3:18 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T7689: Load handles just-in-time
Commits
Restricted Diffusion Commit
rPb717298c9ec0: Remove some callsites to loadViewerHandles()
Summary

Ref T7689. Use the more modern handle load mechanisms in Almanac.

Test Plan
  • Viewed Almanac binding detail page.
  • Viewed Almanac device interface list.
    • Grepped for other callsites to InterfaceTableView.
  • Viewed Almanac binding table.
    • Grepped for other callsites to BindingTableView.
  • Viewed Alamanc service table.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 29649.Apr 9 2015, 10:26 PM
epriestley retitled this revision from to Remove some callsites to loadViewerHandles().
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T7689: Load handles just-in-time.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 9 2015, 10:26 PM
btrahan accepted this revision.Apr 9 2015, 10:26 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 9 2015, 10:26 PM
Closed by commit rPb717298c9ec0: Remove some callsites to loadViewerHandles() (authored by epriestley, committed by epriestley). · Explain WhyApr 9 2015, 11:15 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 29654

View Options

src/applications/almanac/controller/AlmanacBindingViewController.php

Loading...
View Options

src/applications/almanac/controller/AlmanacDeviceViewController.php

Loading...
View Options

src/applications/almanac/controller/AlmanacServiceViewController.php

Loading...
View Options

src/applications/almanac/view/AlmanacBindingTableView.php

Loading...
View Options

src/applications/almanac/view/AlmanacInterfaceTableView.php

Loading...
Phabricator · Built by Phacility