Page MenuHomePhabricator
Differential D12304

Conpherence - implement PhabricatorDestructibleInterface so threads can be deleted
ClosedPublic
Actions

Authored by btrahan on Apr 6 2015, 6:18 PM.
Tags
None
Referenced Files
F15515122: D12304.id29546.diff
Fri, Apr 18, 7:47 AM
F15478097: D12304.id29546.diff
Mon, Apr 7, 8:33 PM
F15475811: D12304.diff
Sun, Apr 6, 11:40 PM
F15462836: D12304.diff
Tue, Apr 1, 5:59 PM
F15401957: D12304.id29546.diff
Mar 17 2025, 7:55 PM
F15369996: D12304.diff
Mar 12 2025, 8:59 AM
F15336537: D12304.id29546.diff
Mar 8 2025, 7:26 PM
Unknown Object (File)
Feb 9 2025, 6:16 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T7756: Conpherence threads should support monograms
T7694: Allow Conpherence threads to be destroyed
Commits
Restricted Diffusion Commit
rPd24b3dcb7de3: Conpherence - implement PhabricatorDestructibleInterface so threads can be…
Summary

Fixes T7694. I had to complicate the ConpherenceThreadQuery code slightly so that if we specify id(s) or phid(s) then we don't bother with all that join stuff we need to make sure we have a reasonable query in production.

Test Plan

bin/remove destroy ZXX worked! tried to visit ZXX and got a nice 404. Clicked around and couldn't find anything broken because of the deletion

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 29546.Apr 6 2015, 6:18 PM
btrahan added a task: T7694: Allow Conpherence threads to be destroyed.
btrahan retitled this revision from to Conpherence - implement PhabricatorDestructibleInterface so threads can be deleted.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptApr 6 2015, 6:18 PM
btrahan added a task: T7756: Conpherence threads should support monograms.Apr 6 2015, 6:19 PM
btrahan mentioned this in T7756: Conpherence threads should support monograms.
epriestley accepted this revision.Apr 8 2015, 7:19 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 8 2015, 7:19 PM
Closed by commit rPd24b3dcb7de3: Conpherence - implement PhabricatorDestructibleInterface so threads can be… (authored by btrahan, committed by btrahan). · Explain WhyApr 8 2015, 7:19 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
1 line
applications/
conpherence/
phid/
30 lines
query/
15 lines
storage/
22 lines

Diff 29633

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/conpherence/phid/PhabricatorConpherenceThreadPHIDType.php

Loading...
View Options

src/applications/conpherence/query/ConpherenceThreadQuery.php

Loading...
View Options

src/applications/conpherence/storage/ConpherenceThread.php

Loading...
Phabricator · Built by Phacility