Page MenuHomePhabricator
Differential D12330

Send Markdown in Diffusion through SourceSans
ClosedPublic
Actions

Authored by chad on Apr 8 2015, 3:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 19, 7:25 AM
Unknown Object (File)
Thu, Dec 19, 7:04 AM
Unknown Object (File)
Thu, Dec 19, 3:50 AM
Unknown Object (File)
Wed, Dec 18, 4:55 AM
Unknown Object (File)
Mon, Dec 16, 4:04 PM
Unknown Object (File)
Fri, Dec 13, 1:25 AM
Unknown Object (File)
Thu, Dec 5, 10:54 PM
Unknown Object (File)
Sat, Nov 30, 9:28 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Commits
Restricted Diffusion Commit
rPff59f4f16bb3: Send Markdown in Diffusion through SourceSans
Summary

This moves Markdown rendering from normal fonts to PHUIDocumentView with Source Sans improving readability of this longer form text.

Test Plan

Test libphutil and Phabricator readmes in my sandbox.

pasted_file (667×889 px, 202 KB)

Diff Detail

Repository
rP Phabricator
Branch
readme-docu-view
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5206
Build 5224: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 29617.Apr 8 2015, 3:36 PM
chad retitled this revision from to Send Markdown in Diffusion through SourceSans.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptApr 8 2015, 3:36 PM
chad edited the test plan for this revision. (Show Details)Apr 8 2015, 3:36 PM
chad added inline comments.
src/applications/diffusion/view/DiffusionReadmeView.php
93

this return felt a little hinky.

epriestley edited edge metadata.Apr 8 2015, 3:38 PM

Can we just always use PHUIDocumentView + SourceSans? Does "README.rainbow" get dramatically worse somehow?

chad added a comment.Apr 8 2015, 3:39 PM

I had no idea what rainbow is/does. if you think it'd work fine I'll update.

epriestley added inline comments.Apr 8 2015, 3:46 PM
src/applications/diffusion/view/DiffusionReadmeView.php
61

You can just add "$interpreter = 'rainbow';" above this line to see it as rainbow.

chad marked an inline comment as done.Apr 8 2015, 4:27 PM
chad updated this revision to Diff 29619.Apr 8 2015, 4:39 PM
chad edited edge metadata.
  • Update, with CSS for mobile/tablet
epriestley accepted this revision.Apr 8 2015, 4:41 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 8 2015, 4:41 PM
Closed by commit rPff59f4f16bb3: Send Markdown in Diffusion through SourceSans (authored by chad, committed by chad). · Explain WhyApr 8 2015, 4:42 PM
This revision was automatically updated to reflect the committed changes.
epriestley mentioned this in D20536: To improve wrapping behavior of rendered README files, don't use "PHUIDocumentView" in Diffusion.May 21 2019, 1:35 PM
epriestley mentioned this in rP5305ebddda9c: To improve wrapping behavior of rendered README files, don't use….May 21 2019, 7:18 PM

Revision Contents
Changeset List

PathSize
resources/
celerity/
2 lines
src/
applications/
diffusion/
view/
30 lines
webroot/
rsrc/
css/
application/
diffusion/
14 lines

Diff 29619

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/diffusion/view/DiffusionReadmeView.php

Loading...
View Options

webroot/rsrc/css/application/diffusion/diffusion-readme.css

Loading...
Phabricator · Built by Phacility