Paths

Table of Contentst

Differential D12322

Fix a failing unit test
ClosedPublic
Actions

Authored by joshuaspence on Apr 8 2015, 1:49 PM.

Tags

None

Referenced Files

	F14026945: D12322.diff
	Fri, Nov 8, 3:56 AM

	F14007737: D12322.id29606.diff
	Tue, Oct 29, 10:47 AM

	F14007736: D12322.id29692.diff
	Tue, Oct 29, 10:47 AM

	F14007735: D12322.id.diff
	Tue, Oct 29, 10:46 AM

	F14007718: D12322.diff
	Tue, Oct 29, 10:30 AM

	F13995809: D12322.id29606.diff
	Wed, Oct 23, 3:44 PM

	F13986141: D12322.id29692.diff
	Mon, Oct 21, 12:54 AM

	F13966017: D12322.diff
	Wed, Oct 16, 5:38 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

rARCe101496508e2: Fix a failing unit test

Summary

D11640 incorrectly changed the line endings in this file.

Test Plan

arc unit

Diff Detail

Repository

Branch

master

Lint

Lint Errors

Severity	Location	Code	Message
Error	src/lint/linter/__tests__/text/dos-newline.lint-test:1	TXT1	DOS Newlines

Unit

Test Failures

Build Status

Buildable 5195
Build 5213: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed
View All

	Time	Test
	1,341 ms	ArcanistPuppetLintLinterTestCase::testLinter
	702 ms	ArcanistCSSLintLinterTestCase::testLinter
	140 ms	ArcanistCSSLintLinterTestCase::testVersion
	146 ms	ArcanistChmodLinterTestCase::testLinter
	237 ms	ArcanistClosureLinterTestCase::testLinter
		View Full Test Results (1 Failed · 48 Passed · 4 Skipped)

Event Timeline

joshuaspence updated this revision to Diff 29606.Apr 8 2015, 1:49 PM

joshuaspence retitled this revision from to Fix a failing unit test.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 8 2015, 1:49 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.Apr 8 2015, 1:59 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Apr 8 2015, 1:59 PM

Closed by commit rARCe101496508e2: Fix a failing unit test (authored by joshuaspence, committed by joshuaspence). · Explain WhyApr 12 2015, 8:47 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

__tests__/

text/

dos-newline.lint-test

4 lines

Diff 29606

src/lint/linter/tests/text/dos-newline.lint-test

Loading...