Page MenuHomePhabricator
Differential D12290

Remove unused `AASTTree::renderAsText` methods
ClosedPublic
Actions

Authored by joshuaspence on Apr 5 2015, 10:11 AM.
Tags
None
Referenced Files
F14476758: D12290.diff
Sat, Dec 28, 7:51 AM
Unknown Object (File)
Fri, Dec 20, 3:02 PM
Unknown Object (File)
Sun, Dec 8, 3:36 PM
Unknown Object (File)
Sat, Nov 30, 5:14 AM
Unknown Object (File)
Nov 26 2024, 7:51 AM
Unknown Object (File)
Nov 6 2024, 4:45 PM
Unknown Object (File)
Oct 29 2024, 5:31 PM
Unknown Object (File)
Oct 25 2024, 12:56 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rPHU6ccd83c7daca: Remove unused `AASTTree::renderAsText` methods
Summary

These methods do not seem to be used.

Test Plan

grep

Diff Detail

Repository
rPHU libphutil
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5145
Build 5163: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 29493.Apr 5 2015, 10:11 AM
joshuaspence retitled this revision from to Remove unused `AASTTree::renderAsText` methods.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 5 2015, 10:11 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Apr 5 2015, 12:16 PM
epriestley edited edge metadata.

IIRC, I added them since they were occasionally useful for debugging, but the XHPAST web UI tool has generally been more helpful since it was introdced.

This revision is now accepted and ready to land.Apr 5 2015, 12:16 PM
joshuaspence updated this revision to Diff 29513.Apr 5 2015, 12:39 PM
joshuaspence edited edge metadata.

Rebase

Closed by commit rPHU6ccd83c7daca: Remove unused `AASTTree::renderAsText` methods (authored by joshuaspence, committed by joshuaspence). · Explain WhyApr 5 2015, 12:42 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
parser/
aast/
api/
14 lines
17 lines

Diff 29513

View Options

src/parser/aast/api/AASTNodeList.php

Loading...
View Options

src/parser/aast/api/AASTTree.php

Loading...
Phabricator · Built by Phacility