Page MenuHomePhabricator
Differential D12277

New Search UI
ClosedPublic
Actions

Authored by chad on Apr 5 2015, 3:59 AM.
Tags
None
Referenced Files
F13219103: D12277.diff
Sat, May 18, 3:22 PM
F13205912: D12277.diff
Wed, May 15, 3:19 AM
F13187174: D12277.diff
Sat, May 11, 4:22 AM
Unknown Object (File)
Tue, May 7, 7:29 AM
Unknown Object (File)
Fri, May 3, 6:21 AM
Unknown Object (File)
Thu, Apr 25, 1:12 AM
Unknown Object (File)
Apr 11 2024, 8:48 AM
Unknown Object (File)
Apr 5 2024, 11:33 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Commits
Restricted Diffusion Commit
rPf4baa3bd1530: New Search UI
Summary

This is the new search UI as seen in Pholio. Unrounds it (mostly, and makes the eyeglass more button like.

Test Plan

Review in all header colors, check photoshop for pixel layout consistency. Review in FF, Chrome, Safari, IE. Make sure I didn't mess up mobile.

pasted_file (58×455 px, 15 KB)

Diff Detail

Repository
rP Phabricator
Branch
new-search-bar
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5119
Build 5137: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 29475.Apr 5 2015, 3:59 AM
chad retitled this revision from to New Search UI.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptApr 5 2015, 3:59 AM
chad edited the test plan for this revision. (Show Details)Apr 5 2015, 3:59 AM

Going to do some more testing on this, but feels complete.

chad planned changes to this revision.Apr 5 2015, 4:20 AM

Browsers are all good, but I want to clean up mobile some more.

chad updated this revision to Diff 29583.Apr 7 2015, 5:28 PM
  • Update mobile search states
chad added a comment.Apr 7 2015, 5:32 PM

This should be good to go. Tested everything I could think of, including Windows Firefox and IE!

epriestley accepted this revision.Apr 7 2015, 6:52 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 7 2015, 6:52 PM
Closed by commit rPf4baa3bd1530: New Search UI (authored by chad, committed by chad). · Explain WhyApr 7 2015, 7:03 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
view/
page/
menu/
2 lines
webroot/
rsrc/
css/
application/
base/
35 lines

Diff 29475

View Options

resources/celerity/map.php

Loading...
View Options

src/view/page/menu/PhabricatorMainMenuSearchView.php

Loading...
View Options

webroot/rsrc/css/application/base/main-menu-view.css

Loading...
Phabricator · Built by Phacility