Page MenuHomePhabricator
Differential D12263

Enforce that global locks have keys shorter than 64 characters
ClosedPublic
Actions

Authored by epriestley on Apr 2 2015, 4:10 PM.
Tags
None
Referenced Files
F14406959: D12263.id29450.diff
Mon, Dec 23, 11:42 PM
Unknown Object (File)
Mon, Dec 16, 9:33 AM
Unknown Object (File)
Mon, Dec 16, 9:33 AM
Unknown Object (File)
Mon, Dec 16, 9:33 AM
Unknown Object (File)
Mon, Dec 16, 9:31 AM
Unknown Object (File)
Fri, Dec 6, 9:24 AM
Unknown Object (File)
Fri, Dec 6, 1:51 AM
Unknown Object (File)
Thu, Nov 28, 3:47 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T7484: Lock is not locked by this process
Commits
Restricted Diffusion Commit
rP2b3d3cf7e4c0: Enforce that global locks have keys shorter than 64 characters
Summary

Fixes T7484. There's a bunch of spooky mystery here but the current behavior can probably cause problems in at least some situations.

Also moves a couple callsigns to monograms (see T4245).

Test Plan
  • Faked a short lock length to hit the exception.
  • Updated normally.
  • Grepped for other use sites, none seemed suspicious or likely to overflow the lock length.

Diff Detail

Repository
rP Phabricator
Branch
locklength
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5103
Build 5121: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 29450.Apr 2 2015, 4:10 PM
epriestley retitled this revision from to Enforce that global locks have keys shorter than 64 characters.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T7484: Lock is not locked by this process.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 2 2015, 4:10 PM
btrahan accepted this revision.Apr 2 2015, 8:07 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 2 2015, 8:07 PM
Closed by commit rP2b3d3cf7e4c0: Enforce that global locks have keys shorter than 64 characters (authored by epriestley, committed by epriestley). · Explain WhyApr 2 2015, 8:42 PM
This revision was automatically updated to reflect the committed changes.
cburroughs mentioned this in T7484: Lock is not locked by this process.Apr 8 2015, 6:20 PM

Revision Contents
Changeset List

PathSize
src/
applications/
repository/
management/
5 lines
infrastructure/
util/
15 lines
50 lines

Diff 29450

View Options

src/applications/repository/management/PhabricatorRepositoryManagementUpdateWorkflow.php

Loading...
View Options

src/infrastructure/util/PhabricatorGlobalLock.php

Loading...
View Options

src/infrastructure/util/PhabricatorHash.php

Loading...
Phabricator · Built by Phacility