Page MenuHomePhabricator
Differential D12235

Improve rules for embedding files received via email
ClosedPublic
Actions

Authored by epriestley on Apr 1 2015, 12:42 AM.
Tags
None
Referenced Files
F13120302: D12235.diff
Mon, Apr 29, 3:56 PM
Unknown Object (File)
Mon, Apr 29, 4:55 AM
Unknown Object (File)
Thu, Apr 25, 3:01 AM
Unknown Object (File)
Mon, Apr 15, 7:55 AM
Unknown Object (File)
Thu, Apr 11, 11:00 AM
Unknown Object (File)
Wed, Apr 10, 9:27 PM
Unknown Object (File)
Wed, Apr 10, 9:27 PM
Unknown Object (File)
Wed, Apr 10, 8:43 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T7712: Files via email (some) seem not to set author or to mirror "normal" task policy
T7199: Expand the power of "!action" commands in email
Commits
Restricted Diffusion Commit
rPafd86a042057: Improve rules for embedding files received via email
Summary

Ref T7199. Ref T7712. This improves the file rules for email:

  • Embed visible images as thumbnails.
  • Put all other file types in a nice list.

This "fixes" an issue caused by the opposite of the problem described in T7712 -- files being dropped if the default ruleset is too restrictive. T7712 is the real solution here, but use a half-measure for now.

Test Plan
  • Sent mail with two non-images and two images.
  • Got a nice list of non-images and embeds of images.

Diff Detail

Repository
rP Phabricator
Branch
mcom7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5072
Build 5090: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 29394.Apr 1 2015, 12:42 AM
epriestley retitled this revision from to Improve rules for embedding files received via email.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added tasks: T7199: Expand the power of "!action" commands in email, T7712: Files via email (some) seem not to set author or to mirror "normal" task policy.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 1 2015, 12:42 AM
btrahan accepted this revision.Apr 1 2015, 3:06 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 1 2015, 3:06 PM
Closed by commit rPafd86a042057: Improve rules for embedding files received via email (authored by epriestley, committed by epriestley). · Explain WhyApr 1 2015, 3:39 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
conpherence/
mail/
6 lines
metamta/
replyhandler/
48 lines

Diff 29394

View Options

src/applications/conpherence/mail/ConpherenceReplyHandler.php

Loading...
View Options

src/applications/metamta/replyhandler/PhabricatorMailReplyHandler.php

Loading...
Phabricator · Built by Phacility