Page MenuHomePhabricator

Improve rules for embedding files received via email
ClosedPublic

Authored by epriestley on Apr 1 2015, 12:42 AM.
Tags
None
Referenced Files
F14067108: D12235.diff
Tue, Nov 19, 1:15 PM
F13960235: D12235.diff
Oct 14 2024, 10:31 PM
F13960217: D12235.id.diff
Oct 14 2024, 10:27 PM
F13960215: D12235.id29394.diff
Oct 14 2024, 10:26 PM
F13960205: D12235.id29405.diff
Oct 14 2024, 10:24 PM
F13958034: D12235.id.diff
Oct 14 2024, 12:32 PM
F13957926: D12235.id29394.diff
Oct 14 2024, 12:04 PM
Unknown Object (File)
Oct 5 2024, 5:50 PM
Subscribers

Details

Summary

Ref T7199. Ref T7712. This improves the file rules for email:

  • Embed visible images as thumbnails.
  • Put all other file types in a nice list.

This "fixes" an issue caused by the opposite of the problem described in T7712 -- files being dropped if the default ruleset is too restrictive. T7712 is the real solution here, but use a half-measure for now.

Test Plan
  • Sent mail with two non-images and two images.
  • Got a nice list of non-images and embeds of images.

Diff Detail

Repository
rP Phabricator
Branch
mcom7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5072
Build 5090: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Improve rules for embedding files received via email.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 1 2015, 3:06 PM
This revision was automatically updated to reflect the committed changes.