Reduce cleverness of tablet breakpoint adjustment
ClosedPublic
Actions

Authored by epriestley on Mar 31 2015, 8:25 PM.

Details

Reviewers

btrahan
chad

Maniphest Tasks

T7713: device-tablet seems to no longer trigger

Commits

Restricted Diffusion Commit
rPba10e8ed4121: Reduce cleverness of tablet breakpoint adjustment

Summary

Fixes T7713. 2 much math X.X

Specifically, we could end up with some nonsense widths here (smaller than the phone breakpoint) with an initially-hidden column.

Test Plan

Hit tablet breakpoint with column open and closed.

Diff Detail

Repository

rP Phabricator

Branch

tablet

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5060
Build 5078: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 29372.Mar 31 2015, 8:25 PM

epriestley retitled this revision from to Reduce cleverness of tablet breakpoint adjustment.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: btrahan, chad.

epriestley added a task: T7713: device-tablet seems to no longer trigger.

Herald added a subscriber: epriestley. · View Herald TranscriptMar 31 2015, 8:25 PM

btrahan accepted this revision.Mar 31 2015, 8:44 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Mar 31 2015, 8:44 PM

Closed by commit rPba10e8ed4121: Reduce cleverness of tablet breakpoint adjustment (authored by epriestley, committed by epriestley). · Explain WhyMar 31 2015, 8:44 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

24 lines

webroot/

rsrc/

js/

application/

conpherence/

behavior-durable-column.js

10 lines

Diff 29372

View Options

resources/celerity/map.php