Page MenuHomePhabricator
Differential D12219

Hide Search text better
ClosedPublic
Actions

Authored by chad on Mar 31 2015, 4:50 PM.
Tags
None
Referenced Files
F14351783: D12219.id29362.diff
Thu, Dec 19, 10:17 AM
Unknown Object (File)
Fri, Dec 13, 7:53 AM
Unknown Object (File)
Sat, Dec 7, 7:28 PM
Unknown Object (File)
Wed, Dec 4, 9:00 PM
Unknown Object (File)
Sun, Dec 1, 10:51 PM
Unknown Object (File)
Wed, Nov 27, 11:21 PM
Unknown Object (File)
Wed, Nov 20, 8:09 AM
Unknown Object (File)
Wed, Nov 20, 8:09 AM
View All Files
Subscribers
epriestley
Korvin
Tokens
"Orange Medal" token, awarded by btrahan.

Details

Reviewers
epriestley
btrahan
Maniphest Tasks
T7710: Double "Search" word shown in search box in header in Firefox
Commits
Restricted Diffusion Commit
rPd81d8caa9332: Hide Search text better
Summary

Previously, this text was transparent, moved it to a new span and set visibility on it.

Test Plan

review search in FF, Chrome. Text no longer displays.

Diff Detail

Repository
rP Phabricator
Branch
search-btn
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5053
Build 5071: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 29360.Mar 31 2015, 4:50 PM
chad retitled this revision from to Hide Search text better.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMar 31 2015, 4:50 PM
chad added a task: T7710: Double "Search" word shown in search box in header in Firefox.Mar 31 2015, 4:52 PM
epriestley accepted this revision.Mar 31 2015, 4:53 PM
epriestley edited edge metadata.

I think this is only for screen readers, so maybe using the aural stuff is a cleaner fix?

https://secure.phabricator.com/book/phabcontrib/article/assistive_technologies/

This revision is now accepted and ready to land.Mar 31 2015, 4:53 PM
chad updated this revision to Diff 29361.Mar 31 2015, 4:57 PM
chad edited edge metadata.
  • aural
Closed by commit rPd81d8caa9332: Hide Search text better (authored by chad, committed by chad). · Explain WhyMar 31 2015, 4:59 PM
This revision was automatically updated to reflect the committed changes.
btrahan awarded a token.Mar 31 2015, 5:50 PM

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
view/
page/
menu/
9 lines
webroot/
rsrc/
css/
application/
base/
3 lines

Diff 29361

View Options

resources/celerity/map.php

Loading...
View Options

src/view/page/menu/PhabricatorMainMenuSearchView.php

Loading...
View Options

webroot/rsrc/css/application/base/main-menu-view.css

Loading...
Phabricator · Built by Phacility