Page MenuHomePhabricator

Improve handle semantics with HandlePool / HandleList
ClosedPublic

Authored by epriestley on Mar 30 2015, 1:27 AM.
Tags
None
Referenced Files
F14843142: D12202.diff
Sun, Feb 2, 4:04 AM
Unknown Object (File)
Tue, Jan 28, 9:21 PM
Unknown Object (File)
Mon, Jan 27, 11:16 PM
Unknown Object (File)
Fri, Jan 24, 1:55 AM
Unknown Object (File)
Fri, Jan 24, 1:55 AM
Unknown Object (File)
Fri, Jan 24, 1:55 AM
Unknown Object (File)
Tue, Jan 21, 11:18 AM
Unknown Object (File)
Mon, Jan 20, 1:02 PM
Subscribers
Tokens
"Grey Medal" token, awarded by chad.

Details

Summary

Ref T7689, which discusses some of the motivation here. Briefly, these methods are awkward:

  • Controller->loadHandles()
  • Controller->loadViewerHandles()
  • Controller->renderHandlesForPHIDs()

This moves us toward better semantics, less awkwardness, and a more reasonable attack on T7688 which won't double-fetch a bunch of data.

Test Plan
  • Added unit tests.
  • Converted one controller to the new stuff.
    • Viewed countdown lists, saw handles render.

Diff Detail

Repository
rP Phabricator
Branch
param1
Lint
Lint Errors
Unit
Tests Passed
Build Status
Buildable 5033
Build 5051: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Improve handle semantics with HandlePool / HandleList.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 30 2015, 7:54 PM
This revision was automatically updated to reflect the committed changes.