Page MenuHomePhabricator
Differential D12194

Don't treat Quicksand requests as isWorkflow() or isAjax()
ClosedPublic
Actions

Authored by epriestley on Mar 28 2015, 9:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 21, 2:31 PM
Unknown Object (File)
Sat, Dec 21, 8:05 AM
Unknown Object (File)
Wed, Dec 18, 2:15 PM
Unknown Object (File)
Mon, Dec 9, 4:23 PM
Unknown Object (File)
Fri, Dec 6, 10:06 AM
Unknown Object (File)
Wed, Dec 4, 4:05 AM
Unknown Object (File)
Sat, Nov 30, 10:37 PM
Unknown Object (File)
Sat, Nov 30, 1:03 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
chad
Maniphest Tasks
T7061: Some UIs activate dialogs incorrectly when Quicksand is active
Commits
Restricted Diffusion Commit
rP29beb174d3b1: Don't treat Quicksand requests as isWorkflow() or isAjax()
Summary

Fixes T7061. Although it's very simple, I think this is a complete fix.

Quicksand technically is Ajax and uses Workflow as a transport mechanism, but the server should always pretend the user clicked a normal link when rendering.

Test Plan

Links that were autoconverting into dialogs (like "Edit Task") or otherwise making the wrong behavioral choices now work as expected.

Diff Detail

Repository
rP Phabricator
Branch
quick5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5024
Build 5042: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 29309.Mar 28 2015, 9:49 PM
epriestley retitled this revision from to Don't treat Quicksand requests as isWorkflow() or isAjax().
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: chad, btrahan.
epriestley added a task: T7061: Some UIs activate dialogs incorrectly when Quicksand is active.
Herald added a subscriber: epriestley. · View Herald TranscriptMar 28 2015, 9:49 PM
chad accepted this revision.Mar 28 2015, 10:23 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 28 2015, 10:23 PM
Closed by commit rP29beb174d3b1: Don't treat Quicksand requests as isWorkflow() or isAjax() (authored by epriestley, committed by epriestley). · Explain WhyMar 28 2015, 10:45 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
aphront/
4 lines

Diff 29309

View Options

src/aphront/AphrontRequest.php

Loading...
Phabricator · Built by Phacility