Paths

Table of Contentst

Differential D12165

Add --project option to 'arc tasks' workflow.
AbandonedPublic
Actions

Authored by • mholden on Mar 26 2015, 5:52 AM.

Details

Reviewers

epriestley

Maniphest Tasks

T7715: Give `arc` query workflows (arc tasks, arc list) access to ApplicationSearch

Summary

I kept wanting this feature, so I gave it a shot.

Adds support for filtering the arc tasks output to a specific project:
$ arc tasks --project {project or project hashtag}

Test Plan

Tested output when no project or matching hashtag is found (throws exception)
Tested that output is filtered when a correct project or hashtag is specified
Tested that it works correctly in conjunction with existing options.

Diff Detail

Repository

rARC Arcanist

Branch

tasks-with-projects

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4984
Build 5002: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

• mholden updated this revision to Diff 29238.Mar 26 2015, 5:52 AM

• mholden retitled this revision from to Add --project option to 'arc tasks' workflow..

• mholden updated this object.

• mholden edited the test plan for this revision. (Show Details)

• mholden added a reviewer: Blessed Reviewers.

Herald edited edge metadata. · View Herald TranscriptMar 26 2015, 5:52 AM

Herald added a subscriber: epriestley. · View Herald Transcript

• mholden updated this object.Mar 26 2015, 5:57 AM

• mholden edited edge metadata.

I just realized I blew right through the contribution guidelines and didn't open a task for this first.. let me know if I should.

joshuaspence added a subscriber: joshuaspence.Mar 26 2015, 7:04 AM

Come to think of it I'm not sure if I even assigned it to the right reviewers :)

#fail

• mholden added a reviewer: epriestley.Mar 27 2015, 1:35 AM

• mholden removed a reviewer: Blessed Reviewers.

We have a Herald rule make sure the right reviewers are added, which is Blessed Reviewers

Oh -- so I had it right the first time? (I'd added blessed_reviewers myself because i'd seen it somewhere).

@epriestley – any idea when you'll have time to consider this submission?

@mholden feature submissions can take a loooong time to review. :sadpanda: We generally prefer things as tasks first so feedback on features can happen before code. Mostly, we are signing up for long term support, documentation, and upkeep when submissions are taken - so unless it's 'obvious', it can take a long time to get actual feedback without a task.

Contrib guide:
https://secure.phabricator.com/book/phabcontrib/article/contributing_code/

T4778 has a little more on how we prioritize.

Ok thanks! No worries at all. Also, will definitely open a task first in the future

johnny-bit added a subscriber: johnny-bit.Mar 31 2015, 3:00 PM

The user @johnny-bit sent me a message asking me to create a Maniphest task for this diff, as he'd like to subscribe to it and give it a +1.

I'll do that now. I still understand that it could be some time before my patch gets considered and/or reviewed.

• mholden mentioned this in T7715: Give `arc` query workflows (arc tasks, arc list) access to ApplicationSearch.Mar 31 2015, 10:21 PM

• mholden added a task: T7715: Give `arc` query workflows (arc tasks, arc list) access to ApplicationSearch.

@epriestley Your comments in T7715 make perfect sense -- should I abandon this revision?

Yeah, I don't want to pursue adding more flags so this probably doesn't make sense in the upstream.

Closing per above discussion.

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistTasksWorkflow.php

48 lines

Diff 29238

View Options

src/workflow/ArcanistTasksWorkflow.php

Add --project option to 'arc tasks' workflow.AbandonedPublicActions