Fixes T7586. If you can't edit a room, the pertinent UI is greyed out. One exception is the title of the room in the full viewer; this crumb is not disabled as it would be hard to read. Otherwise though, everything is disabled nicely.
Details
Details
- Reviewers
epriestley chad - Maniphest Tasks
- T7586: Implement edit rules for rooms
- Commits
- Restricted Diffusion Commit
rP42a0229a52a4: Conpherence - Implement edit rules for rooms
tried to add participants when I wasn't allowed to and got an error. added participants otherwise okay. tried to edit title when i wasn't allowed and got an error. otherwise okay. left conpherence threads / rooms successfully.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- T7586
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 4980 Build 4998: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
I guess I should be doing the requiresCapabilities stuff in the ConpherenceThreadEditor too
Comment Actions
I guess I should be doing the requiresCapabilities stuff in the ConpherenceThreadEditor too
Yeah, this would be good for completeness. We should ideally probably default everything to require CAN_EDIT, but that would be a lot of work / hard to test.
Everything else looks great.