Differential D12149

Conpherence - implement join / view rules for rooms
ClosedPublic
Actions

Authored by btrahan on Mar 24 2015, 11:25 PM.

Tags

None

Referenced Files

	F14411617: D12149.id29207.diff
	Tue, Dec 24, 11:46 AM

	F14411291: D12149.diff
	Tue, Dec 24, 9:42 AM

	Unknown Object (File)
	Fri, Dec 20, 5:14 PM

	Unknown Object (File)
	Fri, Dec 20, 6:19 AM

	Unknown Object (File)
	Tue, Dec 17, 9:57 AM

	Unknown Object (File)
	Sun, Dec 15, 7:36 AM

	Unknown Object (File)
	Mon, Dec 9, 7:47 PM

	Unknown Object (File)
	Fri, Dec 6, 10:07 PM

Subscribers

Details

Reviewers

epriestley
chad

Maniphest Tasks

T7585: Implement view/join rules for rooms

Commits

Restricted Diffusion Commit
rP25767096c931: Conpherence - implement join / view rules for rooms

Summary

Ref T7585. This implements everything specified, with a few caveats

since rooms you have yet to join can't be viewed in the column yet, the column view has some bugs and isn't expected to work.
the room you're looking at is just pre-pending to the top of the "recent" list

Test Plan

made a room that no one could join. verified when viewing that there was no comment ui. made a room that others could join. verified folks who had yet to join had a "join" button with an area for text. tried joining with / without message text and it worked in both cases

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 29207.Mar 24 2015, 11:25 PM

btrahan added a task: T7585: Implement view/join rules for rooms.

btrahan retitled this revision from to Conpherence - implement join / view rules for rooms.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added a reviewer: chad. · View Herald TranscriptMar 24 2015, 11:25 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

btrahan updated this object.Mar 24 2015, 11:27 PM

btrahan edited edge metadata.

epriestley accepted this revision.Mar 24 2015, 11:45 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Mar 24 2015, 11:45 PM

Closed by commit rP25767096c931: Conpherence - implement join / view rules for rooms (authored by btrahan, committed by btrahan). · Explain WhyMar 25 2015, 1:38 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

24 lines

src/

applications/

conpherence/

constants/

ConpherenceUpdateActions.php

1 line

controller/

ConpherenceListController.php

57 lines

ConpherenceUpdateController.php

55 lines

ConpherenceViewController.php

29 lines

ConpherenceWidgetController.php

20 lines

editor/

ConpherenceEditor.php

13 lines

storage/

ConpherenceThread.php

7 lines

transactions/

editor/

PhabricatorApplicationTransactionEditor.php

4 lines

webroot/

rsrc/

css/

application/

conpherence/

widget-pane.css

12 lines

js/

application/

conpherence/

behavior-menu.js

18 lines

Diff 29211

resources/celerity/map.php

Loading...

src/applications/conpherence/constants/ConpherenceUpdateActions.php

Loading...

src/applications/conpherence/controller/ConpherenceListController.php

Loading...

src/applications/conpherence/controller/ConpherenceUpdateController.php

Loading...

src/applications/conpherence/controller/ConpherenceViewController.php

Loading...

src/applications/conpherence/controller/ConpherenceWidgetController.php

Loading...

src/applications/conpherence/editor/ConpherenceEditor.php

Loading...

src/applications/conpherence/storage/ConpherenceThread.php

Loading...

src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php

Loading...

webroot/rsrc/css/application/conpherence/widget-pane.css

Loading...

webroot/rsrc/js/application/conpherence/behavior-menu.js

Loading...