Page MenuHomePhabricator

Add a linter rule to detect unnecessary semicolons
ClosedPublic

Authored by joshuaspence on Mar 23 2015, 8:23 PM.
Tags
None
Referenced Files
F15418792: D12139.diff
Fri, Mar 21, 1:30 AM
F15406871: D12139.id29180.diff
Tue, Mar 18, 2:23 PM
F15392199: D12139.id.diff
Sat, Mar 15, 1:45 PM
F15391728: D12139.id29180.diff
Sat, Mar 15, 11:22 AM
Unknown Object (File)
Feb 13 2025, 2:05 AM
Unknown Object (File)
Feb 13 2025, 2:05 AM
Unknown Object (File)
Feb 13 2025, 1:57 AM
Unknown Object (File)
Feb 13 2025, 1:25 AM
Subscribers
Tokens
"Love" token, awarded by johnny-bit.

Details

Summary

Ref T7409. Adds a rule to detect unnecessary semicolons. The most common scenario I've seen in the wild is the use of semicolons after a class definition:

class MyClass {
  // ...
};
Test Plan

Added unit tests.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 4954
Build 4972: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Add a linter rule to detect unnecessary semicolons.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 6 2015, 1:06 PM
This revision was automatically updated to reflect the committed changes.