Page MenuHomePhabricator

Fix chunk upload fallback behavior
ClosedPublic

Authored by epriestley on Mar 18 2015, 11:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 18, 5:46 AM
Unknown Object (File)
Wed, Nov 13, 9:39 PM
Unknown Object (File)
Sun, Nov 10, 5:10 AM
Unknown Object (File)
Tue, Nov 5, 11:50 PM
Unknown Object (File)
Sat, Nov 2, 1:56 PM
Unknown Object (File)
Oct 16 2024, 4:26 AM
Unknown Object (File)
Sep 20 2024, 5:02 PM
Unknown Object (File)
Sep 4 2024, 2:33 AM

Details

Summary

Ref T7594. Currently, if a chunk upload fails, we incorrectly swallow the failure and fall back to single-file upload, which will often fail by hitting size limits. This also silences the original error.

Instead, do chunk uploads outside the block so that any exceptions escape, and we don't try to fall back to single-file upload.

Mostly just trying to get more info about what's going wrong on @joshuaspence's install.

Test Plan

Faked an exception in chunk upload, ran arc upload on a big file, saw the exception displayed on the console.

Diff Detail

Repository
rARC Arcanist
Branch
upload2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4924
Build 4942: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Fix chunk upload fallback behavior.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a subscriber: joshuaspence.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 19 2015, 12:32 AM
This revision was automatically updated to reflect the committed changes.