Page MenuHomePhabricator

Add "phabricator.silent" for stopping all outbound events from an install
ClosedPublic

Authored by epriestley on Mar 18 2015, 11:40 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 21, 12:20 AM
Unknown Object (File)
Thu, Dec 12, 1:32 AM
Unknown Object (File)
Wed, Dec 11, 10:33 PM
Unknown Object (File)
Fri, Dec 6, 6:32 PM
Unknown Object (File)
Nov 18 2024, 6:59 PM
Unknown Object (File)
Nov 11 2024, 8:36 PM
Unknown Object (File)
Nov 8 2024, 6:35 AM
Unknown Object (File)
Oct 27 2024, 10:53 PM
Subscribers

Details

Summary

Ref T7522. This is mostly useful in the cluster, but could be useful for external installs too.

If you want to import an instance into a test/dry-run state (in the cluster, to test an import; in the general case, to do something like test new hardware or configuration), you currently risk spamming users with a lot of duplicate notifications. In particular, if Phabricator tracks remotes, both instances will continue importing commits and sending email about them. Both instances will try to publish to mirrors, too, which could be bad news, and both instances will try to update linked services.

Instead, provide a flag to let an instance run in "silent mode", which disables all outbound messaging and data.

We need to remember to support this flag on any new outbound channels, but we add about one of those per year so I think that's reasonable.

Test Plan
  • Flipped config.
  • Saw it void email, feed and mirroring.
  • Didn't test SMS since it's not really in use yet and not convenient to test.
  • (Can you think of any publishing I missed?)

Diff Detail

Repository
rP Phabricator
Branch
silent1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 4921
Build 4939: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Add "phabricator.silent" for stopping all outbound events from an install.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
  • Provide a summary for the config option.
  • Artificially disable this option when running unit tests.
btrahan edited edge metadata.

I think you got all the external touching stuff. Nice work!

This revision is now accepted and ready to land.Mar 18 2015, 2:08 PM
This revision was automatically updated to reflect the committed changes.