Page MenuHomePhabricator
Differential D12104

Conpherence - fix a typo
ClosedPublic
Actions

Authored by btrahan on Mar 17 2015, 11:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 21, 6:30 AM
Unknown Object (File)
Thu, Dec 19, 3:54 AM
Unknown Object (File)
Wed, Dec 18, 12:30 AM
Unknown Object (File)
Mon, Dec 16, 2:48 PM
Unknown Object (File)
Thu, Dec 5, 8:26 PM
Unknown Object (File)
Thu, Dec 5, 9:19 AM
Unknown Object (File)
Nov 19 2024, 9:44 AM
Unknown Object (File)
Nov 15 2024, 6:06 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
chad
Commits
Restricted Diffusion Commit
rP441112c8e293: Conpherence - fix a typo
Summary

this typo broke (at least) renaming the thread from the durable column.

Test Plan

renamed a thread from durable column and it worked

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan updated this revision to Diff 29115.Mar 17 2015, 11:15 PM
btrahan retitled this revision from to Conpherence - fix a typo.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added reviewers: epriestley, chad.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMar 17 2015, 11:15 PM
epriestley accepted this revision.Mar 17 2015, 11:16 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Mar 17 2015, 11:16 PM
btrahan updated this revision to Diff 29117.Mar 17 2015, 11:54 PM
btrahan edited edge metadata.

more bug fixing though T6713 has to be re-opened

Closed by commit rP441112c8e293: Conpherence - fix a typo (authored by btrahan, committed by btrahan). · Explain WhyMar 18 2015, 12:01 AM
This revision was automatically updated to reflect the committed changes.
btrahan mentioned this in T6713: Adding a comment to a conpherence sometimes duplicates the message in the UI.Mar 18 2015, 12:02 AM

Revision Contents
Changeset List

PathSize
resources/
celerity/
42 lines
webroot/
rsrc/
js/
application/
conpherence/
33 lines
2 lines

Diff 29118

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/js/application/conpherence/ConpherenceThreadManager.js

Loading...
View Options

webroot/rsrc/js/application/conpherence/behavior-durable-column.js

Loading...
Phabricator · Built by Phacility