Page MenuHomePhabricator
Differential D12104

Conpherence - fix a typo
ClosedPublic
Actions

Authored by btrahan on Mar 17 2015, 11:15 PM.
Tags
None
Referenced Files
F15511396: D12104.diff
Thu, Apr 17, 2:10 AM
F15506747: D12104.id29117.diff
Tue, Apr 15, 1:53 PM
F15506468: D12104.id.diff
Tue, Apr 15, 11:30 AM
F15506040: D12104.id29115.diff
Tue, Apr 15, 8:05 AM
F15503263: D12104.diff
Mon, Apr 14, 8:22 AM
F15483519: D12104.id29115.diff
Wed, Apr 9, 12:51 PM
F15483518: D12104.id29117.diff
Wed, Apr 9, 12:51 PM
F15415667: D12104.diff
Thu, Mar 20, 7:18 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
chad
Commits
Restricted Diffusion Commit
rP441112c8e293: Conpherence - fix a typo
Summary

this typo broke (at least) renaming the thread from the durable column.

Test Plan

renamed a thread from durable column and it worked

Diff Detail

Repository
rP Phabricator
Branch
conphbug
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4916
Build 4934: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 29115.Mar 17 2015, 11:15 PM
btrahan retitled this revision from to Conpherence - fix a typo.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added reviewers: epriestley, chad.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMar 17 2015, 11:15 PM
epriestley accepted this revision.Mar 17 2015, 11:16 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Mar 17 2015, 11:16 PM
btrahan updated this revision to Diff 29117.Mar 17 2015, 11:54 PM
btrahan edited edge metadata.

more bug fixing though T6713 has to be re-opened

Closed by commit rP441112c8e293: Conpherence - fix a typo (authored by btrahan, committed by btrahan). · Explain WhyMar 18 2015, 12:01 AM
This revision was automatically updated to reflect the committed changes.
btrahan mentioned this in T6713: Adding a comment to a conpherence sometimes duplicates the message in the UI.Mar 18 2015, 12:02 AM

Revision Contents
Changeset List

PathSize
resources/
celerity/
42 lines
webroot/
rsrc/
js/
application/
conpherence/
33 lines
2 lines

Diff 29117

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/js/application/conpherence/ConpherenceThreadManager.js

Loading...
View Options

webroot/rsrc/js/application/conpherence/behavior-durable-column.js

Loading...
Phabricator · Built by Phacility