Page MenuHomePhabricator

Make file upload policies more consistent
ClosedPublic

Authored by epriestley on Mar 17 2015, 12:20 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 20, 5:03 PM
Unknown Object (File)
Fri, Dec 20, 11:04 AM
Unknown Object (File)
Sun, Dec 1, 1:41 AM
Unknown Object (File)
Sun, Dec 1, 12:47 AM
Unknown Object (File)
Sun, Dec 1, 12:46 AM
Unknown Object (File)
Nov 4 2024, 7:51 AM
Unknown Object (File)
Oct 25 2024, 10:39 PM
Unknown Object (File)
Oct 24 2024, 8:59 AM
Subscribers

Details

Summary

Ref T7149. Currently, global drag and drop always uses the most open visibility policy on the install. This was appropriate before the application preference was introduced, but default to the application preference now.

In particular, this supports a default value of "Administrators" in the Phacility cluster.

Also simplify/clean up some code.

Test Plan
  • Set application default policy to "Adminstrators".
  • Uploaded file via drag-and-drop, saw "administrators" policy.
  • Uploaded file via arc upload, saw "administrators" policy.
    • Saw better URI for a text file upload after patch.
  • Uploaded file via drag-and-drop-to-textarea, saw "only viewer" policy.

Diff Detail

Repository
rP Phabricator
Branch
files1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4901
Build 4919: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Make file upload policies more consistent.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 17 2015, 1:51 AM
This revision was automatically updated to reflect the committed changes.