Page MenuHomePhabricator

Enable the chunk storage engine
ClosedPublic

Authored by epriestley on Mar 14 2015, 4:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Feb 8, 3:03 AM
Unknown Object (File)
Sat, Feb 8, 3:03 AM
Unknown Object (File)
Sat, Feb 8, 3:03 AM
Unknown Object (File)
Sun, Feb 2, 9:22 PM
Unknown Object (File)
Thu, Jan 30, 7:02 AM
Unknown Object (File)
Fri, Jan 24, 1:21 AM
Unknown Object (File)
Fri, Jan 24, 1:21 AM
Unknown Object (File)
Fri, Jan 24, 1:21 AM
Subscribers

Details

Summary

Ref T7149. This works now, so enable it.

Test Plan
  • Uploaded large and small files in Firefox, Safari and Chrome.
  • Uploaded large files with arc upload.
  • Stopped/resumed large files with all clients.

Diff Detail

Repository
rP Phabricator
Branch
chunk10
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4885
Build 4903: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Enable the chunk storage engine.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
webroot/rsrc/js/core/DragAndDropFileUpload.js
267–274

This is a simplification: instead of reading the data into JS and then sending it in the request, we can send the Blob directly. This works in all modern browsers, and saves us some mess where Javascript decides to un-binary the data and re-encode it in JS UTF.

btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 15 2015, 6:07 PM
This revision was automatically updated to reflect the committed changes.