Differential D12046

Conpherence - add draft support to column and refine sending message user workflow
ClosedPublic
Actions

Authored by btrahan on Mar 11 2015, 9:37 PM.

Tags

None

Referenced Files

	F14322159: D12046.id28991.diff
	Wed, Dec 18, 12:31 PM

	Unknown Object (File)
	Sat, Dec 14, 3:45 PM

	Unknown Object (File)
	Sun, Dec 8, 7:18 AM

	Unknown Object (File)
	Wed, Dec 4, 11:08 PM

	Unknown Object (File)
	Sun, Nov 24, 10:56 PM

	Unknown Object (File)
	Fri, Nov 22, 8:08 PM

	Unknown Object (File)
	Fri, Nov 22, 8:08 PM

	Unknown Object (File)
	Thu, Nov 21, 12:39 PM

Subscribers

Details

Reviewers

epriestley
chad

Maniphest Tasks

T7014: Annouce Persistent Chat option in Conpherence

Commits

Restricted Diffusion Commit
rP194a183ea6ad: Conpherence - add draft support to column and refine sending message user…

Summary

Ref T7014. This diff adds draft support.

Test Plan

made many comments and they submitted nicely.

Diff Detail

Repository

Branch

T7014_draft

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4847
Build 4863: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 28991.Mar 11 2015, 9:37 PM

btrahan added tasks: T7014: Annouce Persistent Chat option in Conpherence, T7104: Slightly odd-looking error view in empty state of Config setup issues.

btrahan retitled this revision from to Conpherence - add draft support to column and refine sending message user workflow.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added reviewers: epriestley, chad.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMar 11 2015, 9:37 PM

btrahan updated this object.Mar 11 2015, 9:40 PM

btrahan removed a task: T7104: Slightly odd-looking error view in empty state of Config setup issues.

btrahan added inline comments.Mar 11 2015, 9:42 PM

webroot/rsrc/js/application/conpherence/behavior-durable-column.js
99	@chad - just to clarify, this means we no longer use the loading mask when sending a message... We do still use it when initially loading the thread and switching threads via the switcher and that's it.

when a user sends a commit we instantly show our "best effort" pre-rendered draft before ajaxing in the right stuff

I think this is probably bad/undesirable, but I guess we can see how it works in practice.

In particular:

We render invalid username mentions differently in previews vs submitted text.
T4411 adds more similar rules.
Users with a lost connection may believe their message sent when it did not.

epriestley accepted this revision.Mar 11 2015, 9:44 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Mar 11 2015, 9:44 PM

I'm fine with the round trip, it's mostly that it looks like the entire thread is reloading that seemed overkill.

Alright, can someone look at D12043 at least? I feel like this UI has regressed today and at least if D12043 gets in there I will feel like things are back to par.

scoping down to just draft support

btrahan reclaimed this revision.Mar 11 2015, 10:53 PM

This revision is now accepted and ready to land.Mar 11 2015, 10:53 PM

btrahan updated this object.Mar 11 2015, 10:53 PM

btrahan edited the test plan for this revision. (Show Details)

Closed by commit rP194a183ea6ad: Conpherence - add draft support to column and refine sending message user… (authored by btrahan, committed by btrahan). · Explain WhyMar 11 2015, 10:54 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

74 lines

src/

applications/

conpherence/

controller/

ConpherenceColumnViewController.php

5 lines

view/

ConpherenceDurableColumnView.php

21 lines

webroot/

rsrc/

js/

application/

conpherence/

ConpherenceThreadManager.js

19 lines

behavior-durable-column.js

7 lines

behavior-menu.js

23 lines

Diff 28994

resources/celerity/map.php

Loading...

src/applications/conpherence/controller/ConpherenceColumnViewController.php

Loading...

src/applications/conpherence/view/ConpherenceDurableColumnView.php

Loading...

webroot/rsrc/js/application/conpherence/ConpherenceThreadManager.js

Loading...

webroot/rsrc/js/application/conpherence/behavior-durable-column.js

Loading...

webroot/rsrc/js/application/conpherence/behavior-menu.js

Loading...