Differential D12043

Conpherence - smooth out user interaction switching threads in the durable column
ClosedPublic
Actions

Authored by btrahan on Mar 11 2015, 7:23 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Jan 28, 5:52 PM

	Unknown Object (File)
	Fri, Jan 24, 1:47 AM

	Unknown Object (File)
	Fri, Jan 24, 1:12 AM

	Unknown Object (File)
	Fri, Jan 24, 1:12 AM

	Unknown Object (File)
	Fri, Jan 24, 1:12 AM

	Unknown Object (File)
	Fri, Jan 24, 1:12 AM

	Unknown Object (File)
	Thu, Jan 23, 8:12 PM

	Unknown Object (File)
	Tue, Jan 21, 11:00 AM

Subscribers

Details

Reviewers

epriestley
chad

Maniphest Tasks

T7014: Annouce Persistent Chat option in Conpherence

Commits

Restricted Diffusion Commit
rPd9adedd9d64d: Conpherence - smooth out user interaction switching threads in the durable…

Summary

Ref T7014. This changes the title and selected icon right as the user clicks it. This could maybe be in the "willLoadThread" callback hook, but it doesn't happen every time we load a thread, just this time so keep it right in the listener for now.

Test Plan

switched some threads and liked what I saw

Diff Detail

Repository

Branch

T7014_5

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4841
Build 4857: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 28987.Mar 11 2015, 7:23 PM

btrahan added a task: T7014: Annouce Persistent Chat option in Conpherence.

btrahan retitled this revision from to Conpherence - smooth out user interaction switching threads in the durable column.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added reviewers: epriestley, chad.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMar 11 2015, 7:23 PM

btrahan mentioned this in D12046: Conpherence - add draft support to column and refine sending message user workflow.Mar 11 2015, 9:37 PM

Closed by commit rPd9adedd9d64d: Conpherence - smooth out user interaction switching threads in the durable… (authored by btrahan, committed by btrahan). · Explain WhyMar 11 2015, 10:55 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

22 lines

src/

applications/

conpherence/

view/

ConpherenceDurableColumnView.php

1 line

webroot/

rsrc/

js/

application/

conpherence/

behavior-durable-column.js

13 lines

Diff 28987

resources/celerity/map.php

Loading...

src/applications/conpherence/view/ConpherenceDurableColumnView.php

Loading...

webroot/rsrc/js/application/conpherence/behavior-durable-column.js

Loading...