Ref T7014. This diff adds draft support.
Details
Details
- Reviewers
epriestley chad - Maniphest Tasks
- T7014: Annouce Persistent Chat option in Conpherence
- Commits
- Restricted Diffusion Commit
rP194a183ea6ad: Conpherence - add draft support to column and refine sending message user…
made many comments and they submitted nicely.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
when a user sends a commit we instantly show our "best effort" pre-rendered draft before ajaxing in the right stuff
I think this is probably bad/undesirable, but I guess we can see how it works in practice.
In particular:
- We render invalid username mentions differently in previews vs submitted text.
- T4411 adds more similar rules.
- Users with a lost connection may believe their message sent when it did not.
Comment Actions
I'm fine with the round trip, it's mostly that it looks like the entire thread is reloading that seemed overkill.