Page MenuHomePhabricator

Conpherence - add draft support to column and refine sending message user workflow
ClosedPublic

Authored by btrahan on Mar 11 2015, 9:37 PM.
Tags
None
Referenced Files
F14057097: D12046.diff
Sun, Nov 17, 12:23 AM
F14022085: D12046.diff
Wed, Nov 6, 3:12 PM
F13977266: D12046.id28991.diff
Oct 18 2024, 5:53 PM
F13958127: D12046.id.diff
Oct 14 2024, 1:04 PM
Unknown Object (File)
Sep 29 2024, 5:18 AM
Unknown Object (File)
Sep 17 2024, 6:33 PM
Unknown Object (File)
Sep 12 2024, 6:26 AM
Unknown Object (File)
Sep 9 2024, 2:31 PM
Subscribers

Details

Summary

Ref T7014. This diff adds draft support.

Test Plan

made many comments and they submitted nicely.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan retitled this revision from to Conpherence - add draft support to column and refine sending message user workflow.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added reviewers: epriestley, chad.
webroot/rsrc/js/application/conpherence/behavior-durable-column.js
99

@chad - just to clarify, this means we no longer use the loading mask when sending a message...

We do still use it when initially loading the thread and switching threads via the switcher and that's it.

when a user sends a commit we instantly show our "best effort" pre-rendered draft before ajaxing in the right stuff

I think this is probably bad/undesirable, but I guess we can see how it works in practice.

In particular:

  • We render invalid username mentions differently in previews vs submitted text.
  • T4411 adds more similar rules.
  • Users with a lost connection may believe their message sent when it did not.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Mar 11 2015, 9:44 PM

I'm fine with the round trip, it's mostly that it looks like the entire thread is reloading that seemed overkill.

Alright, can someone look at D12043 at least? I feel like this UI has regressed today and at least if D12043 gets in there I will feel like things are back to par.

btrahan edited edge metadata.

scoping down to just draft support

This revision is now accepted and ready to land.Mar 11 2015, 10:53 PM
btrahan edited the test plan for this revision. (Show Details)
This revision was automatically updated to reflect the committed changes.