Page MenuHomePhabricator
Differential D12028

Extend TransactionCommentQuery for Diffusion
ClosedPublic
Actions

Authored by epriestley on Mar 9 2015, 7:52 PM.
Tags
None
Referenced Files
F13145428: D12028.diff
Fri, May 3, 9:04 AM
Unknown Object (File)
Wed, May 1, 3:12 PM
Unknown Object (File)
Thu, Apr 25, 2:44 AM
Unknown Object (File)
Tue, Apr 16, 8:09 PM
Unknown Object (File)
Tue, Apr 16, 8:09 PM
Unknown Object (File)
Tue, Apr 16, 7:46 PM
Unknown Object (File)
Tue, Apr 16, 6:23 PM
Unknown Object (File)
Thu, Apr 11, 9:59 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity
T1460: Add "Done" link to an inline comment
Commits
Restricted Diffusion Commit
rPdaa893e50876: Extend TransactionCommentQuery for Diffusion
Summary

Ref T2009. Ref T1460. Reduces the amount of garbage involved in loading inline comments and routes more pathways through the proper Query layer.

Test Plan

Viewed, edited, previewed, submitted inline comments in Diffusion.

Diff Detail

Repository
rP Phabricator
Branch
uni36
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 4821
Build 4837: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 28951.Mar 9 2015, 7:52 PM
epriestley retitled this revision from to Extend TransactionCommentQuery for Diffusion.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added tasks: T1460: Add "Done" link to an inline comment, T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity.
Herald added a subscriber: epriestley. · View Herald TranscriptMar 9 2015, 7:52 PM
btrahan accepted this revision.Mar 9 2015, 8:43 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 9 2015, 8:43 PM
Closed by commit rPdaa893e50876: Extend TransactionCommentQuery for Diffusion (authored by epriestley, committed by epriestley). · Explain WhyMar 9 2015, 9:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
2 lines
applications/
audit/
storage/
29 lines
diffusion/
query/
62 lines
infrastructure/
diff/
41 lines

Diff 28951

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/applications/audit/storage/PhabricatorAuditInlineComment.php

Loading...
View Options

src/applications/diffusion/query/DiffusionDiffInlineCommentQuery.php

Loading...
View Options

src/infrastructure/diff/PhabricatorInlineCommentController.php

Loading...
Phabricator · Built by Phacility