Page MenuHomePhabricator
Differential D12025

Write "hasReplies" to database for inline comments
ClosedPublic
Actions

Authored by epriestley on Mar 9 2015, 6:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 29, 4:23 PM
Unknown Object (File)
Sun, Apr 28, 9:36 PM
Unknown Object (File)
Sun, Apr 28, 8:00 AM
Unknown Object (File)
Sat, Apr 27, 11:49 PM
Unknown Object (File)
Thu, Apr 25, 12:03 AM
Unknown Object (File)
Tue, Apr 16, 8:09 PM
Unknown Object (File)
Tue, Apr 16, 8:09 PM
Unknown Object (File)
Tue, Apr 16, 7:46 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
Restricted Maniphest Task
T1460: Add "Done" link to an inline comment
Commits
Restricted Diffusion Commit
rP2972894a4df9: Write "hasReplies" to database for inline comments
Summary

Ref T1460. Ref T2618.

When publishing a draft inline, mark the inline it replies to (if any) as replied to.

Also, don't load deleted comments as drafts (sets the stage for T2618).

I'll make an effort to clean up the loading mess here in the next revision, and find some more appropriate home for the shared code.

Test Plan

Made and replied to comments in Differential and Diffusion. Saw comments get marked as "Has Replies" and "Is Reply".

Diff Detail

Repository
rP Phabricator
Branch
uni33
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/infrastructure/diff/PhabricatorInlineCommentController.php:315XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 4817
Build 4833: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 28946.Mar 9 2015, 6:56 PM
epriestley retitled this revision from to Write "hasReplies" to database for inline comments.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added tasks: T1460: Add "Done" link to an inline comment, Restricted Maniphest Task.
Herald added a subscriber: epriestley. · View Herald TranscriptMar 9 2015, 6:56 PM
btrahan accepted this revision.Mar 9 2015, 8:36 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 9 2015, 8:36 PM
Closed by commit rP2972894a4df9: Write "hasReplies" to database for inline comments (authored by epriestley, committed by epriestley). · Explain WhyMar 9 2015, 9:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 28946

View Options

src/applications/audit/editor/PhabricatorAuditEditor.php

Loading...
View Options

src/applications/audit/storage/PhabricatorAuditInlineComment.php

Loading...
View Options

src/applications/audit/storage/PhabricatorAuditTransactionComment.php

Loading...
View Options

src/applications/differential/editor/DifferentialTransactionEditor.php

Loading...
View Options

src/applications/differential/query/DifferentialTransactionQuery.php

Loading...
View Options

src/applications/differential/storage/DifferentialTransactionComment.php

Loading...
View Options

src/infrastructure/diff/PhabricatorInlineCommentController.php

Loading...
Phabricator · Built by Phacility