Page MenuHomePhabricator
Differential D12018

Reduce code duplication on comment editing UI
ClosedPublic
Actions

Authored by epriestley on Mar 8 2015, 9:01 PM.
Tags
None
Referenced Files
F13221420: D12018.diff
Sun, May 19, 2:45 AM
F13210130: D12018.id28941.diff
Fri, May 17, 4:10 AM
F13206115: D12018.diff
Wed, May 15, 5:17 AM
F13203804: D12018.diff
Wed, May 15, 12:07 AM
F13186370: D12018.diff
Sat, May 11, 3:35 AM
Unknown Object (File)
Tue, May 7, 6:38 AM
Unknown Object (File)
Sat, May 4, 9:46 PM
Unknown Object (File)
Sat, May 4, 1:35 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
chad
Maniphest Tasks
T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity
Commits
Restricted Diffusion Commit
rP355142fcbf23: Reduce code duplication on comment editing UI
Summary

Ref T2009. This has two more copies of the scaffolding.

Test Plan

Created, edited, deleted, replied to inline comments.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 28927.Mar 8 2015, 9:01 PM
epriestley retitled this revision from to Reduce code duplication on comment editing UI.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity.
Herald added a reviewer: chad. · View Herald TranscriptMar 8 2015, 9:01 PM
Herald added a subscriber: epriestley. · View Herald Transcript
epriestley added inline comments.Mar 8 2015, 9:07 PM
webroot/rsrc/css/application/differential/changeset-view.css
426–431

I just dropped this since it's nonstandard and doesn't seem hugely important, but we can put something back in T7503 if we want.

chad accepted this revision.Mar 8 2015, 11:31 PM
chad edited edge metadata.
This revision is now accepted and ready to land.Mar 8 2015, 11:31 PM
Closed by commit rP355142fcbf23: Reduce code duplication on comment editing UI (authored by epriestley, committed by epriestley). · Explain WhyMar 9 2015, 5:27 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
infrastructure/
diff/
25 lines
view/
27 lines
webroot/
rsrc/
css/
application/
differential/
7 lines

Diff 28941

View Options

src/infrastructure/diff/PhabricatorInlineCommentController.php

Loading...
View Options

src/infrastructure/diff/view/PHUIDiffInlineCommentEditView.php

Loading...
View Options

webroot/rsrc/css/application/differential/changeset-view.css

Loading...
Phabricator · Built by Phacility