Page MenuHomePhabricator

Reduce code duplication for inline "Undo"
ClosedPublic

Authored by epriestley on Mar 8 2015, 10:28 PM.
Tags
None
Referenced Files
F15410136: D12019.diff
Wed, Mar 19, 6:49 AM
F15389661: D12019.id28943.diff
Sat, Mar 15, 5:32 AM
F15386228: D12019.id28928.diff
Sat, Mar 15, 12:12 AM
F15382341: D12019.id28943.diff
Fri, Mar 14, 11:56 AM
F15367462: D12019.diff
Tue, Mar 11, 6:51 PM
F15298749: D12019.diff
Wed, Mar 5, 1:43 PM
Unknown Object (File)
Sun, Feb 23, 5:29 AM
Unknown Object (File)
Sun, Feb 23, 5:29 AM
Subscribers

Details

Summary

Ref T2009. This is another almost-identical copy of the row scaffolding, which has the same 1up/2up bugs as the 8 other copies of this code.

Turn the "undo" element into an InlineCommentView so we can scaffold it.

Then, scaffold it with the same code as everything else.

Test Plan

Hit "Undo", swapped from 1up to 2up, hit "undo" again, swapped back, tried left/right, everything rendered with proper scaffolding.

Diff Detail

Repository
rP Phabricator
Branch
uni29
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 4810
Build 4826: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Reduce code duplication for inline "Undo".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
chad edited edge metadata.
chad added inline comments.
src/infrastructure/diff/view/PHUIDiffInlineCommentUndoView.php
37

pht

This revision is now accepted and ready to land.Mar 8 2015, 11:32 PM
This revision was automatically updated to reflect the committed changes.