Page MenuHomePhabricator
Differential D12017

Explicitly track inline comment reply threading
ClosedPublic
Actions

Authored by epriestley on Mar 8 2015, 8:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 8:02 AM
Unknown Object (File)
Mon, Apr 22, 10:45 PM
Unknown Object (File)
Thu, Apr 18, 11:19 AM
Unknown Object (File)
Sun, Apr 7, 10:16 PM
Unknown Object (File)
Thu, Apr 4, 12:31 AM
Unknown Object (File)
Wed, Apr 3, 4:15 PM
Unknown Object (File)
Wed, Apr 3, 4:14 PM
Unknown Object (File)
Sun, Mar 31, 10:31 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T1460: Add "Done" link to an inline comment
Commits
Restricted Diffusion Commit
rP082b7f95e6e6: Explicitly track inline comment reply threading
Summary

Ref T1460. Track and store which comments are threaded replies to other comments, vs merely appearing on the same lines.

This doesn't actually write hasReplies yet, since that needs to happen when we un-draft comments on submission.

Test Plan

Made inline comments in Differential and Diffusion, including replies. Replies were marked as "Is Reply".

Diff Detail

Repository
rP Phabricator
Branch
uni27
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php:111XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 4808
Build 4824: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 28926.Mar 8 2015, 8:09 PM
epriestley retitled this revision from to Explicitly track inline comment reply threading.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T1460: Add "Done" link to an inline comment.
Herald added a subscriber: epriestley. · View Herald TranscriptMar 8 2015, 8:09 PM
btrahan accepted this revision.Mar 9 2015, 5:20 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 9 2015, 5:20 PM
Closed by commit rP082b7f95e6e6: Explicitly track inline comment reply threading (authored by epriestley, committed by epriestley). · Explain WhyMar 9 2015, 5:27 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
42 lines
src/
applications/
audit/
storage/
28 lines
differential/
controller/
6 lines
query/
13 lines
storage/
19 lines
diffusion/
controller/
4 lines
infrastructure/
diff/
44 lines
interface/
6 lines
view/
12 lines
32 lines
webroot/
rsrc/
js/
application/
differential/
10 lines
13 lines

Diff 28926

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/audit/storage/PhabricatorAuditInlineComment.php

Loading...
View Options

src/applications/differential/controller/DifferentialInlineCommentEditController.php

Loading...
View Options

src/applications/differential/query/DifferentialInlineCommentQuery.php

Loading...
View Options

src/applications/differential/storage/DifferentialInlineComment.php

Loading...
View Options

src/applications/diffusion/controller/DiffusionInlineCommentController.php

Loading...
View Options

src/infrastructure/diff/PhabricatorInlineCommentController.php

Loading...
View Options

src/infrastructure/diff/interface/PhabricatorInlineCommentInterface.php

Loading...
View Options

src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php

Loading...
View Options

src/infrastructure/diff/view/PHUIDiffInlineCommentEditView.php

Loading...
View Options

webroot/rsrc/js/application/differential/DifferentialInlineCommentEditor.js

Loading...
View Options

webroot/rsrc/js/application/differential/behavior-edit-inline-comments.js

Loading...
Phabricator · Built by Phacility