Differential D12015

Respect unified view in Diffusion
ClosedPublic
Actions

Authored by epriestley on Mar 8 2015, 6:21 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity

Commits

Restricted Diffusion Commit
rP7a9768fc795f: Respect unified view in Diffusion

Summary

Ref T2009. Respect preference and make 1up/2up options work properly.

Test Plan

Toggled 1up vs 2up in Diffusion.

Diff Detail

Repository

rP Phabricator

Branch

uni26

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4806
Build 4822: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 28923.Mar 8 2015, 6:21 PM

epriestley retitled this revision from to Respect unified view in Diffusion.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity.

Herald added a subscriber: epriestley. · View Herald TranscriptMar 8 2015, 6:21 PM

btrahan accepted this revision.Mar 9 2015, 5:15 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Mar 9 2015, 5:15 PM

Closed by commit rP7a9768fc795f: Respect unified view in Diffusion (authored by epriestley, committed by epriestley). · Explain WhyMar 9 2015, 5:27 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

controller/

DiffusionDiffController.php

9 lines

Diff 28923

View Options

src/applications/diffusion/controller/DiffusionDiffController.php

Respect unified view in DiffusionClosedPublicActions