Page MenuHomePhabricator
Differential D12003

Make images work in the unified diff view
ClosedPublic
Actions

Authored by epriestley on Mar 6 2015, 5:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 29, 6:23 PM
Unknown Object (File)
Mon, Jan 27, 2:36 AM
Unknown Object (File)
Fri, Jan 24, 12:59 AM
Unknown Object (File)
Fri, Jan 24, 12:59 AM
Unknown Object (File)
Fri, Jan 24, 12:59 AM
Unknown Object (File)
Fri, Jan 24, 12:59 AM
Unknown Object (File)
Tue, Jan 21, 9:57 AM
Unknown Object (File)
Sat, Jan 18, 7:15 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity
Commits
Restricted Diffusion Commit
rP68fa70eacbc8: Make images work in the unified diff view
Summary

Ref T2009. Still a touch glitch-ish but essentially functional now.

Test Plan

Viewed image diffs in 1up and 2up views. Made inline comments on them.

Diff Detail

Event Timeline

epriestley updated this revision to Diff 28892.Mar 6 2015, 5:39 PM
epriestley retitled this revision from to Make images work in the unified diff view.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity.
Herald added a subscriber: epriestley. · View Herald TranscriptMar 6 2015, 5:39 PM
btrahan accepted this revision.Mar 6 2015, 11:01 PM
btrahan edited edge metadata.
btrahan added inline comments.
src/applications/differential/render/DifferentialChangesetHTMLRenderer.php
578

What's with the word "Stage" here? Maybe renderImageChange ?

This revision is now accepted and ready to land.Mar 6 2015, 11:01 PM
epriestley added inline comments.Mar 6 2015, 11:02 PM
src/applications/differential/render/DifferentialChangesetHTMLRenderer.php
582

Just this, the class is called a "stage". It's like a theatrical stage for presenting the image, not a rocket booster stage.

Closed by commit rP68fa70eacbc8: Make images work in the unified diff view (authored by epriestley, committed by epriestley). · Explain WhyMar 6 2015, 11:06 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 28892

View Options

src/applications/differential/render/DifferentialChangesetHTMLRenderer.php

Loading...
View Options

src/applications/differential/render/DifferentialChangesetOneUpRenderer.php

Loading...
View Options

src/applications/differential/render/DifferentialChangesetTwoUpRenderer.php

Loading...
Phabricator · Built by Phacility