Ref T2009. Still a touch glitch-ish but essentially functional now.
Details
Details
- Reviewers
btrahan - Maniphest Tasks
- T2009: Refactor DifferentialChangesetParser to support 1-up views and sanity
- Commits
- Restricted Diffusion Commit
rP68fa70eacbc8: Make images work in the unified diff view
Viewed image diffs in 1up and 2up views. Made inline comments on them.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- uni20
- Lint
Lint Passed Severity Location Code Message Advice src/applications/differential/render/DifferentialChangesetOneUpRenderer.php:167 XHP16 TODO Comment Advice src/applications/differential/render/DifferentialChangesetOneUpRenderer.php:192 XHP16 TODO Comment - Unit
Tests Passed - Build Status
Buildable 4791 Build 4807: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
| src/applications/differential/render/DifferentialChangesetHTMLRenderer.php | ||
|---|---|---|
| 578 | What's with the word "Stage" here? Maybe renderImageChange ? | |
| src/applications/differential/render/DifferentialChangesetHTMLRenderer.php | ||
|---|---|---|
| 582 | Just this, the class is called a "stage". It's like a theatrical stage for presenting the image, not a rocket booster stage. | |