Page MenuHomePhabricator

Rename inline comment views to "PHUIDiff" and give them a base class
ClosedPublic

Authored by epriestley on Mar 6 2015, 1:13 PM.
Tags
None
Referenced Files
F19939052: D11996.diff
Tue, Apr 14, 9:15 AM
F19914412: D11996.diff
Fri, Apr 3, 10:57 AM
F19894510: D11996.id28894.diff
Sat, Mar 28, 3:14 PM
F19889153: D11996.id28884.diff
Tue, Mar 24, 9:08 AM
F19866376: D11996.id.diff
Mar 14 2026, 6:57 PM
F19846638: D11996.diff
Mar 12 2026, 1:21 PM
F19838226: D11996.diff
Mar 11 2026, 4:28 PM
F19836725: D11996.id.diff
Mar 11 2026, 1:20 PM
Subscribers

Details

Summary

Ref T2009. These classes are "Differential" now, but are used elsewhere in diff infrastructure (e.g., Diffusion).

  • Rename them to "PHUIDiff".
  • Move them to "src/infrastructure/".
  • Give them a base class.
Test Plan

Interacted with inlines in unified and side-by-side views.

Diff Detail

Repository
rP Phabricator
Branch
uni16
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 4783
Build 4799: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Rename inline comment views to "PHUIDiff" and give them a base class.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 6 2015, 10:57 PM
This revision was automatically updated to reflect the committed changes.