Page MenuHomePhabricator

Rename inline comment views to "PHUIDiff" and give them a base class
ClosedPublic

Authored by epriestley on Mar 6 2015, 1:13 PM.
Tags
None
Referenced Files
F18505096: D11996.id.diff
Fri, Sep 5, 12:23 AM
F18496699: D11996.diff
Thu, Sep 4, 5:37 PM
F18486993: D11996.diff
Wed, Sep 3, 7:08 PM
F18106250: D11996.id.diff
Aug 10 2025, 10:02 PM
F18106087: D11996.id28894.diff
Aug 10 2025, 9:06 PM
F18105923: D11996.diff
Aug 10 2025, 8:35 PM
F18093914: D11996.id28884.diff
Aug 7 2025, 9:22 PM
F18089580: D11996.id28884.diff
Aug 6 2025, 11:48 AM
Subscribers

Details

Summary

Ref T2009. These classes are "Differential" now, but are used elsewhere in diff infrastructure (e.g., Diffusion).

  • Rename them to "PHUIDiff".
  • Move them to "src/infrastructure/".
  • Give them a base class.
Test Plan

Interacted with inlines in unified and side-by-side views.

Diff Detail

Repository
rP Phabricator
Branch
uni16
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 4783
Build 4799: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Rename inline comment views to "PHUIDiff" and give them a base class.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 6 2015, 10:57 PM
This revision was automatically updated to reflect the committed changes.