Add untracked files to commit using prompt
ClosedPublic
Actions

Authored by nevogd on Mar 6 2015, 8:17 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC3d871b42146e: Add untracked files to commit using prompt

Required Signatures

L28 Phacility Individual Contributor License Agreement

Summary

Refs D11990. When using arc diff with untracked files in the working
copy, add the untracked file(s) to the commit (as they weren't stashed or
ignored). Add the untracked paths to the list of changes in the editor
template, indicating that the files were added to the commit.

This doesn't add a separate prompt to add untracked files as per the
behaviour prior to D11843.

Test Plan

Ran arc diff with only untracked files, answered yes to the 'create
new commit' prompt. Saw the commit-message with the updated changes
including untracked files. Completed the arc template, and got commit
containing uncommitted, unstaged and untracked files.

Diff Detail

Repository

rARC Arcanist

Branch

diff_workflow

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4782
Build 4798: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

nevogd updated this revision to Diff 28882.Mar 6 2015, 8:17 AM

nevogd retitled this revision from to Add untracked files to commit using prompt.

nevogd updated this object.

nevogd edited the test plan for this revision. (Show Details)

nevogd added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMar 6 2015, 8:17 AM

Herald added a required legal document: L28 Phacility Individual Contributor License Agreement. · View Herald Transcript

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

nevogd mentioned this in T7465: arc diff does not prompt to add untracked files using git.Mar 6 2015, 8:20 AM

This looks good, but you need to sign the CLA before I can merge it (see link in header).

Signed CLA as requested

epriestley accepted this revision.Mar 6 2015, 12:40 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Mar 6 2015, 12:40 PM

Closed by commit rARC3d871b42146e: Add untracked files to commit using prompt (authored by nevogd, committed by epriestley). · Explain WhyMar 6 2015, 12:41 PM

This revision was automatically updated to reflect the committed changes.

In the past, diff workflows allowed us to skip adding untracked files to the revision and continue with the workflow.

Is the expected behavior here that if you say No to adding the untracked files to the commit, that the workflow should abort? If so, don't we lose that previous functionality?

• sshannin added a subscriber: • sshannin.Mar 10 2015, 3:08 AM

staticshock mentioned this in T7521: `arc land` should work even when the repo has untracked files.Mar 10 2015, 6:54 PM

• sshannin mentioned this in T7608: arcanist - allow untracked files.Mar 17 2015, 6:30 PM