Page MenuHomePhabricator
Differential D11992

Fix another issue with line order on unified diffs
ClosedPublic
Actions

Authored by epriestley on Mar 5 2015, 11:47 PM.
Tags
None
Referenced Files
F13233472: D11992.diff
Tue, May 21, 2:20 AM
F13231275: D11992.id28875.diff
Tue, May 21, 12:20 AM
F13216175: D11992.id28876.diff
Fri, May 17, 10:49 PM
F13215713: D11992.id.diff
Fri, May 17, 7:21 PM
F13213044: D11992.diff
Fri, May 17, 7:18 AM
Unknown Object (File)
Fri, May 3, 6:15 AM
Unknown Object (File)
Thu, Apr 25, 1:04 AM
Unknown Object (File)
Apr 14 2024, 2:36 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Commits
Restricted Diffusion Commit
rPb3d1ecebc7f8: Fix another issue with line order on unified diffs
Summary

This improves some cases with interleaved added and removed lines, and adds test coverage.

Test Plan
  • Added and executed unit tests.
  • Viewed raw diff and saw sensible/expected output.

Diff Detail

Repository
rP Phabricator
Branch
uni14
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningsrc/applications/differential/__tests__/data/order.diff:1TXT3Line Too Long
Unit
Tests Passed
Build Status
Buildable 4777
Build 4793: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 28875.Mar 5 2015, 11:47 PM
epriestley retitled this revision from to Fix another issue with line order on unified diffs.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
Herald added a subscriber: epriestley. · View Herald TranscriptMar 5 2015, 11:47 PM
btrahan accepted this revision.Mar 6 2015, 12:22 AM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 6 2015, 12:22 AM
Closed by commit rPb3d1ecebc7f8: Fix another issue with line order on unified diffs (authored by epriestley, committed by epriestley). · Explain WhyMar 6 2015, 12:24 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
__tests__/
data/
24 lines
26 lines
44 lines
render/
7 lines
5 lines

Diff 28875

View Options

src/applications/differential/__tests__/data/order.diff

Loading...
View Options

src/applications/differential/__tests__/data/order.diff.one.expect

Loading...
View Options

src/applications/differential/__tests__/data/order.diff.two.expect

Loading...
View Options

src/applications/differential/render/DifferentialChangesetRenderer.php

Loading...
View Options

src/applications/differential/render/DifferentialChangesetTestRenderer.php

Loading...
Phabricator · Built by Phacility