Differential D11991

Conpherence - get the durable column header actions working correctly
ClosedPublic
Actions

Authored by btrahan on Mar 5 2015, 11:23 PM.

Tags

None

Referenced Files

	F14833549: D11991.id.diff
	Thu, Jan 30, 11:02 AM

	F14831982: D11991.id.diff
	Thu, Jan 30, 3:45 AM

	Unknown Object (File)
	Mon, Jan 27, 5:25 AM

	Unknown Object (File)
	Mon, Jan 27, 3:53 AM

	Unknown Object (File)
	Fri, Jan 24, 12:55 AM

	Unknown Object (File)
	Fri, Jan 24, 12:55 AM

	Unknown Object (File)
	Fri, Jan 24, 12:55 AM

	Unknown Object (File)
	Fri, Jan 24, 12:55 AM

Subscribers

Details

Reviewers

epriestley
chad

Maniphest Tasks

T7014: Annouce Persistent Chat option in Conpherence

Commits

Restricted Diffusion Commit
rPc97040de4707: Conpherence - get the durable column header actions working correctly

Summary

Ref T7014. This diff addresses

getting it to be the right set of options
- add participant
- view in conpherence
- close window
making those options work
make it so if you are on /conpherence/ you can't toggle the durable column

Test Plan

inspected dom via chrome tools and found last transaction. added a participant and inspected the single new transactin added for accuracy. used view in conpherence action to view in conpherence. used close window action to close window

Diff Detail

Repository

Branch

conphaction

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4776
Build 4792: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 28873.Mar 5 2015, 11:23 PM

btrahan retitled this revision from to Conpherence - get the durable column header actions working correctly.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added reviewers: epriestley, chad.

btrahan added a task: T7014: Annouce Persistent Chat option in Conpherence.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMar 5 2015, 11:23 PM

Unified is a bit more busted than I thought, diffs coming..

This revision is now accepted and ready to land.Mar 5 2015, 11:30 PM

Closed by commit rPc97040de4707: Conpherence - get the durable column header actions working correctly (authored by btrahan, committed by btrahan). · Explain WhyMar 5 2015, 11:32 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

47 lines

src/

applications/

conpherence/

controller/

ConpherenceUpdateController.php

7 lines

view/

ConpherenceDurableColumnView.php

40 lines

webroot/

rsrc/

js/

application/

aphlict/

behavior-aphlict-dropdown.js

4 lines

conpherence/

behavior-durable-column.js

92 lines

Diff 28873

resources/celerity/map.php

Loading...

src/applications/conpherence/controller/ConpherenceUpdateController.php

Loading...

src/applications/conpherence/view/ConpherenceDurableColumnView.php

Loading...

webroot/rsrc/js/application/aphlict/behavior-aphlict-dropdown.js

Loading...

webroot/rsrc/js/application/conpherence/behavior-durable-column.js

Loading...