Page MenuHomePhabricator

Conpherence - get the durable column header actions working correctly
ClosedPublic

Authored by btrahan on Mar 5 2015, 11:23 PM.
Tags
None
Referenced Files
F18048488: D11991.id.diff
Sun, Aug 3, 1:36 PM
F17937526: D11991.id28873.diff
Thu, Jul 31, 1:18 AM
F17883632: D11991.id28873.diff
Jul 28 2025, 11:27 PM
F17738581: D11991.diff
Jul 21 2025, 12:05 AM
Unknown Object (File)
Jun 26 2025, 4:58 PM
Unknown Object (File)
Jun 26 2025, 8:33 AM
Unknown Object (File)
Jun 26 2025, 7:08 AM
Unknown Object (File)
May 21 2025, 4:00 AM
Subscribers

Details

Summary

Ref T7014. This diff addresses

  • getting it to be the right set of options
    • add participant
    • view in conpherence
    • close window
  • making those options work
  • make it so if you are on /conpherence/ you can't toggle the durable column
Test Plan

inspected dom via chrome tools and found last transaction. added a participant and inspected the single new transactin added for accuracy. used view in conpherence action to view in conpherence. used close window action to close window

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan retitled this revision from to Conpherence - get the durable column header actions working correctly.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added reviewers: epriestley, chad.
epriestley edited edge metadata.

Unified is a bit more busted than I thought, diffs coming..

This revision is now accepted and ready to land.Mar 5 2015, 11:30 PM
This revision was automatically updated to reflect the committed changes.